fix(NODE-6328): pass through optional options in txn APIs (#45)

Author: nbbeeken

readme.md

@@ -62,7 +62,7 @@ In your existing project add `mongodb-legacy` to your `package.json` with the fo
 npm install mongodb-legacy
 ```
 
-	
+
 ### Release Integrity
 
 Releases are created automatically and signed using the [Node team's GPG key](https://pgp.mongodb.com/node-driver.asc). This applies to the git tag as well as all release packages provided as part of a GitHub release. To verify the provided packages, download the key and import it using gpg:
@@ -74,9 +74,9 @@ gpg --import node-driver.asc
 The GitHub release contains a detached signature file for the NPM package (named
 `mongodb-legacy-X.Y.Z.tgz.sig`).
 
-The following command returns the link npm package. 
+The following command returns the link npm package.
 ```shell
-npm view [email protected] dist.tarball 
+npm view [email protected] dist.tarball
 ```
 
 Using the result of the above command, a `curl` command can return the official npm package for the release.
@@ -86,10 +86,8 @@ To verify the integrity of the downloaded package, run the following command:
 gpg --verify mongodb-legacy-X.Y.Z.tgz.sig mongodb-legacy-X.Y.Z.tgz
 ```
 
->[!Note]
-No verification is done when using npm to install the package. The contents of the Github tarball and npm's tarball are identical.
-
-```
+>[!NOTE]
+> No verification is done when using npm to install the package. The contents of the Github tarball and npm's tarball are identical.
 
 ### Versioning
 

src/legacy_wrappers/session.js

@@ -7,12 +7,28 @@ Object.defineProperty(module.exports, '__esModule', { value: true });
 
 module.exports.makeLegacyClientSession = function (baseClass) {
   class LegacyClientSession extends baseClass {
-    abortTransaction(callback) {
-      return maybeCallback(super.abortTransaction(), callback);
+    abortTransaction(options, callback) {
+      callback =
+        typeof callback === 'function'
+          ? callback
+          : typeof options === 'function'
+            ? options
+            : undefined;
+      options = typeof options !== 'function' ? options : undefined;
+
+      return maybeCallback(super.abortTransaction(options), callback);
     }
 
-    commitTransaction(callback) {
-      return maybeCallback(super.commitTransaction(), callback);
+    commitTransaction(options, callback) {
+      callback =
+        typeof callback === 'function'
+          ? callback
+          : typeof options === 'function'
+            ? options
+            : undefined;
+      options = typeof options !== 'function' ? options : undefined;
+
+      return maybeCallback(super.commitTransaction(options), callback);
     }
 
     endSession(options, callback) {

test/tools/api.js

@@ -57,8 +57,8 @@ const api = [
   { className: 'ChangeStream', method: 'next', returnType: 'Promise<TChange>' },
   { className: 'ChangeStream', method: 'tryNext', returnType: 'Promise<Document | null>' },
 
-  { className: 'ClientSession', method: 'abortTransaction', returnType: 'Promise<Document>' },
-  { className: 'ClientSession', method: 'commitTransaction', returnType: 'Promise<Document>' },
+  { className: 'ClientSession', method: 'abortTransaction', returnType: 'Promise<Document>', possibleCallbackPositions: [1, 2] },
+  { className: 'ClientSession', method: 'commitTransaction', returnType: 'Promise<Document>', possibleCallbackPositions: [1, 2] },
   { className: 'ClientSession', method: 'endSession', returnType: 'Promise<void>' },
   { className: 'ClientSession', method: 'withTransaction', returnType: 'Promise<void>', notAsync: true },