COMPASS-9674: add to special collections

Author: johnjackweir

index.d.ts

@@ -4,16 +4,16 @@ class NS {
   database: string;
   collection: string;
   system: boolean;
-  isSystem: boolean;
+  isSystem(): boolean;
   oplog: boolean;
-  isOplog: boolean;
+  isOplog(): boolean;
   command: boolean;
-  isCommand: boolean;
+  isCommand(): boolean;
   special: boolean;
-  isSpecial: boolean;
+  isSpecial(): boolean;
   specialish: boolean;
   normal: boolean;
-  isNormal: boolean;
+  isNormal(): boolean;
   validDatabaseName: boolean;
   validCollectionName: boolean;
   databaseHash: number;

index.js

@@ -16,13 +16,14 @@ function NS(ns) {
     this.collection = ns.slice(this.dotIndex + 1);
   }
 
-  this.system = /^(?:system|enxcol_)\./.test(this.collection);
+  this.system = /^(?:system(?!\.profile$).*|enxcol_)\./.test(this.collection);
+
   this.oplog = /local\.oplog\.(\$main|rs)/.test(ns);
 
   this.command =
     this.collection === '$cmd' || this.collection.indexOf('$cmd.sys') === 0;
   this.special =
-    this.oplog || this.command || this.system || this.database === 'config';
+    this.oplog || this.command || this.system || this.database === 'config' || /^__mdb_internal_\w/.test(this.database);
 
   this.specialish =
     this.special || ['local', 'admin'].indexOf(this.database) > -1;

test.js

@@ -35,9 +35,9 @@ describe('ns', function() {
     assert.equal(ns('local.oplog.$foo').oplog, false);
   });
 
-  it('should identify special namespaces', function() {
-    it('should acccept `a.$.b`', function() {
-      assert(ns('a.$.b').special);
+  describe('should identify special namespaces', function() {
+    it('should NOT accept `a.$.b as special`', function() {
+      assert.equal(ns('a.$.b').special, false);
     });
     it('should acccept `a.system.foo`', function() {
       assert(ns('a.system.foo').special);
@@ -54,6 +54,43 @@ describe('ns', function() {
     it('should not accept `a.foo.system.bar`', function() {
       assert.equal(ns('a.foo.system.bar').special, false);
     });
+    it('should not accept `prefix__mdb_internal_suffix`', function() {
+      assert.equal(ns('prefix__mdb_internal_suffix').special, false);
+    });
+    it('should not accept `anyDB.prefix__mdb_internal_suffix`', function() {
+      assert.equal(ns('anyDB.prefix__mdb_internal_itsACollectionNow').special, false);
+    });
+    it('should not accept `prefix__mdb_internal_suffix`', function() {
+      assert.equal(ns('prefix__mdb_internal_').special, false);
+    });
+    it('should acccept `__mdb_internal_suffix`', function() {
+      assert(ns('__mdb_internal_suffix').special);
+    });
+  });
+
+  describe('should identify system namespaces', function() {
+    it('should acccept `anyDB.enxcol_.` as system`', function() {
+      assert(ns('anyDB.enxcol_.').system);
+    });
+    it('should acccept `anyDB.system.` as system`', function() {
+      assert(ns('anyDB.system.').system);
+    });
+    it('should acccept `anyDB.system.anyCollSuffix` as system`', function() {
+      assert(ns('anyDB.system.anyCollSuffix').system);
+    });
+    it('should NOT acccept `anyDB.anyCollPrefix.system` as system`', function() {
+      assert.equal((ns('anyDB.anyCollPrefix.system').system), false);
+    });
+    it('should NOT acccept `anyDB.system` as system`', function() {
+      assert.equal((ns('anyDB.system').system), false);
+    });
+    // exception for system.profile COMPASS-9377
+    it('should NOT acccept `anyDB.system.profile as system`', function() {
+      assert.equal((ns('anyDB.system.profile').system), false);
+    });
+    it('should acccept `anyDB.system.profile_anything as system`', function() {
+      assert(ns('anyDB.system.profile_anything').system);
+    });
   });
 
   describe('database name validation', function() {