feat(webview): update feature flag to always show new connection form VSCODE-490 (#637)

Author: Anemy

src/featureFlags.ts

@@ -1,5 +1,5 @@
 const FEATURE_FLAGS = {
-  useNewConnectionForm: `${process.env.MDB_USE_NEW_CONNECTION_FORM}` === 'true',
+  useOldConnectionForm: `${process.env.MDB_USE_OLD_CONNECTION_FORM}` === 'true',
 };
 
 export type FeatureFlag = keyof typeof FEATURE_FLAGS;

src/test/suite/views/webview-app/app.test.tsx

@@ -7,15 +7,15 @@ import App from '../../../../views/webview-app/app';
 
 describe('App Component Test Suite', () => {
   afterEach(() => sinon.restore());
-  test('it renders the old overview page when useNewConnectionForm is falsy', () => {
+  test('it renders the old overview page when useOldConnectionForm is falsy', () => {
     sinon.stub(featureFlags, 'getFeatureFlag').returns(false);
     render(<App />);
-    expect(() => screen.getAllByTestId('legacy-app')).does.not.throw;
+    expect(screen.queryByTestId('legacy-app')).to.be.null;
   });
 
-  test('it renders the new overview page when useNewConnectionForm is truthy', () => {
+  test('it renders the new overview page when useOldConnectionForm is truthy', () => {
     sinon.stub(featureFlags, 'getFeatureFlag').returns(true);
     render(<App />);
-    expect(screen.queryByTestId('legacy-app')).to.be.null;
+    expect(() => screen.getAllByTestId('legacy-app')).does.not.throw;
   });
 });

src/views/webview-app/app.tsx

@@ -8,12 +8,12 @@ import { useDetectVsCodeDarkMode } from './use-detect-vscode-dark-mode';
 const App: React.FC = () => {
   const darkMode = useDetectVsCodeDarkMode();
 
-  return getFeatureFlag('useNewConnectionForm') ? (
+  return getFeatureFlag('useOldConnectionForm') ? (
+    <LegacyApp />
+  ) : (
     <LeafyGreenProvider darkMode={darkMode}>
       <OverviewPage />
     </LeafyGreenProvider>
-  ) : (
-    <LegacyApp />
   );
 };