fix(explorer): auto-open connection when done connecting, fix auto open on delete VSCODE-325 VSCODE-398 (#619)

Author: Anemy

src/explorer/explorerTreeController.ts

@@ -173,7 +173,12 @@ export default class ExplorerTreeController
         this._connectionTreeItems[connection.id] = new ConnectionTreeItem({
           connectionId: connection.id,
           collapsibleState: connectionExpandedState,
-          isExpanded: isActiveConnection,
+          // Set expanded when we're connecting to a connection so that it
+          // expands when it's connected.
+          isExpanded:
+            isBeingConnectedTo ||
+            connectionExpandedState ===
+              vscode.TreeItemCollapsibleState.Expanded,
           connectionController: this._connectionController,
           cacheIsUpToDate: pastConnectionTreeItems[connection.id]
             ? pastConnectionTreeItems[connection.id].cacheIsUpToDate

src/test/suite/explorer/explorerController.test.ts

@@ -152,10 +152,11 @@ suite('Explorer Controller Test Suite', function () {
     const connectionName =
       testConnectionController._connections[connectionId].name;
 
-    assert(
-      connectionName === 'localhost:27088',
-      `Expected active connection name to be 'localhost:27088' found ${connectionName}`
-    );
+    const connectionsItemsFirstConnect = await treeController.getChildren();
+
+    assert.strictEqual(connectionName, 'localhost:27088');
+    // Ensure we auto expand when it's successfully connected to.
+    assert(connectionsItemsFirstConnect[0].isExpanded);
 
     try {
       await testConnectionController.addNewConnectionStringAndConnect(