VSCODE-119: Do not check for babel config (#98)

* fix: do not check for babel config

* Add sinon types, bump shell-api version, fix typing errors in tests

* build: rename badge

* refactor: trigger azure

Co-authored-by: Rhys Howell <rhys@[email protected]>

Author: alenakhineika

README.md

@@ -1,6 +1,6 @@
 # MongoDB for VS Code ![PREVIEW](https://img.shields.io/badge/-PREVIEW-orange)
 
-[![Build Status](https://dev.azure.com/team-compass/vscode/_apis/build/status/mongodb-js.vscode?branchName=master)](https://dev.azure.com/team-compass/vscode/_build/latest?definitionId=6&branchName=master)
+[![Build Status](https://dev.azure.com/team-compass/vscode/_apis/build/status/mongodb-js.vscode?branchName=master)](https://dev.azure.com/team-compass/vscode/_build/latest?definitionId=10&branchName=master)
 
 MongoDB for VS Code makes it easy to work with MongoDB, whether your own instance or in [MongoDB Atlas](https://www.mongodb.com/cloud/atlas/register).
 
@@ -25,15 +25,15 @@ MongoDB Playgrounds are the most convenient way to prototype and execute CRUD op
 
 ![Playgrounds](resources/screenshots/playground.png)
 
-*Make sure you are connected to a server or cluster before using a playground. You can't run a playground and you won't get completions if you are not connected.*
+_Make sure you are connected to a server or cluster before using a playground. You can't run a playground and you won't get completions if you are not connected._
 
 ### Quick access to the MongoDB Shell
 
 Launch the MongoDB Shell from the command palette to quickly connect to the same cluster you have active in VS Code.
 
 ![MongoDB Shell](resources/screenshots/shell-launcher.png)
 
-*The shell binary needs to be in your `$PATH`. This functionality has some issues on Windows, we'll release an update with a fix soon.*
+_The shell binary needs to be in your `$PATH`. This functionality has some issues on Windows, we'll release an update with a fix soon._
 
 ### Terraform snippet for MongoDB Atlas
 
@@ -56,7 +56,7 @@ If you use Terraform to manage your infrastructure, MongoDB for VS Code helps yo
 
 ## Additional Settings
 
-*These global settings affect how MongoDB for VS Code provides intelligent autocomplete inside snippets and string literals (off by default). Changing the default configuration may affect the behavior and performance of other extensions and of VS Code itself. If you do not change the default settings, you can still trigger intelligent autocomplete inside a snippet or string literal with `Ctrl+Space`.*
+_These global settings affect how MongoDB for VS Code provides intelligent autocomplete inside snippets and string literals (off by default). Changing the default configuration may affect the behavior and performance of other extensions and of VS Code itself. If you do not change the default settings, you can still trigger intelligent autocomplete inside a snippet or string literal with `Ctrl+Space`._
 
 - `editor.suggest.snippetsPreventQuickSuggestions`: By default, VS Code prevents code completion in snippet mode (editing placeholders in inserted code). Setting this to `false` allows snippet (eg. `$match`, `$addFields`) and field completion based on the document schema for the `db.collection.aggregate()` expressions.
 - `editor.quickSuggestions`: By default, VS Code prevents code completion inside string literals. To enable database names completions for `use('dbName')` expression use this configuration:
@@ -93,6 +93,7 @@ npm run local-install
 This will compile and package MongoDB for VS Code into a `.vsix` file and add the extension to your VS Code.
 
 To install this locally on windows:
+
 ```shell
 npm install
 .\node_modules\.bin\vsce.cmd package

package-lock.json

@@ -608,9 +608,9 @@
     "@fortawesome/free-solid-svg-icons": "^5.13.0",
     "@fortawesome/react-fontawesome": "^0.1.9",
     "@leafygreen-ui/toggle": "^3.0.0",
-    "@mongosh/browser-runtime-electron": "0.0.1-alpha.14",
-    "@mongosh/service-provider-server": "0.0.1-alpha.14",
-    "@mongosh/shell-api": "0.0.1-alpha.14",
+    "@mongosh/browser-runtime-electron": "0.0.1-alpha.15",
+    "@mongosh/service-provider-server": "0.0.1-alpha.15",
+    "@mongosh/shell-api": "0.0.1-alpha.15",
     "analytics-node": "^3.4.0-beta.1",
     "bson": "^4.0.3",
     "classnames": "^2.2.6",
@@ -644,6 +644,7 @@
     "@types/node": "^13.7.1",
     "@types/react": "^16.9.25",
     "@types/react-dom": "^16.9.5",
+    "@types/sinon": "^9.0.1",
     "@types/vscode": "^1.41.0",
     "@types/ws": "^7.2.4",
     "@typescript-eslint/eslint-plugin": "^2.19.2",

package.json

@@ -26,11 +26,13 @@ const log = createLogger('editors controller');
 export default class EditorsController {
   _connectionController: ConnectionController;
   _collectionDocumentsOperationsStore = new CollectionDocumentsOperationsStore();
-
   _collectionViewProvider: CollectionDocumentsProvider;
   _documentViewProvider: DocumentProvider;
 
-  constructor(context: vscode.ExtensionContext, connectionController: ConnectionController) {
+  constructor(
+    context: vscode.ExtensionContext,
+    connectionController: ConnectionController
+  ) {
     log.info('activating...');
     this._connectionController = connectionController;
 
@@ -42,18 +44,23 @@ export default class EditorsController {
 
     context.subscriptions.push(
       vscode.workspace.registerTextDocumentContentProvider(
-        VIEW_COLLECTION_SCHEME, collectionViewProvider
+        VIEW_COLLECTION_SCHEME,
+        collectionViewProvider
       )
     );
     this._collectionViewProvider = collectionViewProvider;
 
-    context.subscriptions.push(vscode.languages.registerCodeLensProvider(
-      {
-        scheme: VIEW_COLLECTION_SCHEME,
-        language: 'json'
-      },
-      new CollectionDocumentsCodeLensProvider(this._collectionDocumentsOperationsStore)
-    ));
+    context.subscriptions.push(
+      vscode.languages.registerCodeLensProvider(
+        {
+          scheme: VIEW_COLLECTION_SCHEME,
+          language: 'json'
+        },
+        new CollectionDocumentsCodeLensProvider(
+          this._collectionDocumentsOperationsStore
+        )
+      )
+    );
 
     const documentViewProvider = new DocumentProvider(
       connectionController,
@@ -62,7 +69,8 @@ export default class EditorsController {
 
     context.subscriptions.push(
       vscode.workspace.registerTextDocumentContentProvider(
-        VIEW_DOCUMENT_SCHEME, documentViewProvider
+        VIEW_DOCUMENT_SCHEME,
+        documentViewProvider
       )
     );
     this._documentViewProvider = documentViewProvider;
@@ -81,7 +89,9 @@ export default class EditorsController {
       value: documentId
     });
 
-    const documentIdUriQuery = `${DOCUMENT_ID_URI_IDENTIFIER}=${encodeURIComponent(documentIdString)}`;
+    const documentIdUriQuery = `${DOCUMENT_ID_URI_IDENTIFIER}=${encodeURIComponent(
+      documentIdString
+    )}`;
     const namespaceUriQuery = `${NAMESPACE_URI_IDENTIFIER}=${namespace}`;
 
     // We attach the current time to ensure a new editor window is opened on
@@ -90,19 +100,24 @@ export default class EditorsController {
 
     // The part of the URI after the scheme and before the query is the file name.
     const textDocumentUri = vscode.Uri.parse(
-      `${VIEW_DOCUMENT_SCHEME}:${namespace}: ${JSON.stringify(documentId)} - ${Date.now()}.json${uriQuery}`
+      `${VIEW_DOCUMENT_SCHEME}:${namespace}: ${JSON.stringify(
+        documentId
+      )} - ${Date.now()}.json${uriQuery}`
     );
     return new Promise((resolve, reject) => {
       vscode.workspace.openTextDocument(textDocumentUri).then((doc) => {
-        vscode.window.showTextDocument(doc, { preview: false }).then(
-          () => resolve(true),
-          reject
-        );
+        vscode.window
+          .showTextDocument(doc, { preview: false })
+          .then(() => resolve(true), reject);
       }, reject);
     });
   }
 
-  static getViewCollectionDocumentsUri(operationId, namespace, connectionId): vscode.Uri {
+  static getViewCollectionDocumentsUri(
+    operationId,
+    namespace,
+    connectionId
+  ): vscode.Uri {
     // We attach a unique id to the query so that it creates a new file in
     // the editor and so that we can virtually manage the amount of docs shown.
     const operationIdUriQuery = `${OPERATION_ID_URI_IDENTIFIER}=${operationId}`;
@@ -129,32 +144,42 @@ export default class EditorsController {
     );
     return new Promise((resolve, reject) => {
       vscode.workspace.openTextDocument(uri).then((doc) => {
-        vscode.window.showTextDocument(doc, { preview: false }).then(
-          () => resolve(true),
-          reject
-        );
+        vscode.window
+          .showTextDocument(doc, { preview: false })
+          .then(() => resolve(true), reject);
       }, reject);
     });
   }
 
-  onViewMoreCollectionDocuments(operationId: string, connectionId: string, namespace: string): Promise<boolean> {
+  onViewMoreCollectionDocuments(
+    operationId: string,
+    connectionId: string,
+    namespace: string
+  ): Promise<boolean> {
     log.info('view more collection documents', namespace);
 
     // A user might click to fetch more documents multiple times,
     // this ensures it only performs one fetch at a time.
-    if (this._collectionDocumentsOperationsStore.operations[operationId].isCurrentlyFetchingMoreDocuments) {
+    if (
+      this._collectionDocumentsOperationsStore.operations[operationId]
+        .isCurrentlyFetchingMoreDocuments
+    ) {
       vscode.window.showErrorMessage('Already fetching more documents...');
       return Promise.resolve(false);
     }
 
     // Ensure we're still connected to the correct connection.
     if (connectionId !== this._connectionController.getActiveConnectionId()) {
-      vscode.window.showErrorMessage(`Unable to view more documents: no longer connected to ${connectionId}`);
+      vscode.window.showErrorMessage(
+        `Unable to view more documents: no longer connected to ${connectionId}`
+      );
       return Promise.resolve(false);
     }
 
     if (!this._collectionViewProvider) {
-      return Promise.reject(new Error('No registered collection view provider.'));
+      return Promise.reject(
+        new Error('No registered collection view provider.')
+      );
     }
 
     const uri = EditorsController.getViewCollectionDocumentsUri(
@@ -163,7 +188,9 @@ export default class EditorsController {
       connectionId
     );
 
-    this._collectionDocumentsOperationsStore.increaseOperationDocumentLimit(operationId);
+    this._collectionDocumentsOperationsStore.increaseOperationDocumentLimit(
+      operationId
+    );
 
     // Notify the document provider to update with the new document limit.
     this._collectionViewProvider.onDidChangeEmitter.fire(uri);

src/editors/editorsController.ts

@@ -70,10 +70,10 @@ export default class PlaygroundController {
       if (
         editor &&
         editor.document &&
-        !editor.document.uri.path.includes('extension-output')
+        editor.document.languageId === 'mongodb'
       ) {
         this._activeTextEditor = editor;
-        log.info('Active editor uri', editor.document.uri.path);
+        log.info('Active editor path', editor.document.uri?.path);
       }
     });
   }
@@ -172,8 +172,12 @@ export default class PlaygroundController {
               return resolve(null);
             });
 
-            const codeToEvaluate =
-              this._activeTextEditor?.document.getText() || '';
+            let codeToEvaluate = '';
+
+            if (this._activeTextEditor && this._activeTextEditor.document) {
+              codeToEvaluate = this._activeTextEditor.document.getText() || '';
+            }
+
             // Run all playground scripts.
             const result = await this.evaluate(codeToEvaluate);
 

src/editors/playgroundController.ts

@@ -42,7 +42,11 @@ suite('Connection Controller Test Suite', function () {
   beforeEach(() => {
     // Here we stub the showInformationMessage process because it is too much
     // for the render process and leads to crashes while testing.
-    sinon.replace(vscode.window, 'showInformationMessage', sinon.stub());
+    sinon.replace(
+      vscode.window,
+      'showInformationMessage',
+      sinon.fake.resolves(true)
+    );
   });
 
   afterEach(async () => {
@@ -155,8 +159,8 @@ suite('Connection Controller Test Suite', function () {
       await testConnectionController.disconnect();
 
       assert(
-        fakeVscodeErrorMessage.firstArg === expectedMessage,
-        `Expected error message "${expectedMessage}" when disconnecting with no active connection, recieved "${fakeVscodeErrorMessage.firstArg}"`
+        fakeVscodeErrorMessage.firstCall.args[0] === expectedMessage,
+        `Expected error message "${expectedMessage}" when disconnecting with no active connection, recieved "${fakeVscodeErrorMessage.firstCall.args[0]}"`
       );
     } catch (error) {
       assert(!!error, 'Expected an error disconnect response.');
@@ -245,8 +249,8 @@ suite('Connection Controller Test Suite', function () {
       await testConnectionController.disconnect();
 
       assert(
-        fakeVscodeErrorMessage.firstArg === expectedMessage,
-        `Expected "${expectedMessage}" when disconnecting while connecting, recieved "${fakeVscodeErrorMessage.firstArg}"`
+        fakeVscodeErrorMessage.firstCall.args[0] === expectedMessage,
+        `Expected "${expectedMessage}" when disconnecting while connecting, recieved "${fakeVscodeErrorMessage.firstCall.args[0]}"`
       );
     } catch (error) {
       assert(!!error, 'Expected an error disconnect response.');
@@ -265,8 +269,8 @@ suite('Connection Controller Test Suite', function () {
       await testConnectionController.disconnect();
 
       assert(
-        fakeVscodeErrorMessage.firstArg === expectedMessage,
-        `Expected "${expectedMessage}" when disconnecting while already disconnecting, recieved "${fakeVscodeErrorMessage.firstArg}"`
+        fakeVscodeErrorMessage.firstCall.args[0] === expectedMessage,
+        `Expected "${expectedMessage}" when disconnecting while already disconnecting, recieved "${fakeVscodeErrorMessage.firstCall.args[0]}"`
       );
     } catch (error) {
       assert(!!error, 'Expected an error disconnect response.');
@@ -486,9 +490,9 @@ suite('Connection Controller Test Suite', function () {
   });
 
   test('a connection can be connected to by id', async () => {
-    const getConnection = (TEST_DATABASE_URI): Promise<any> =>
+    const getConnection = (dbUri): Promise<any> =>
       new Promise((resolve, reject) => {
-        Connection.from(TEST_DATABASE_URI, (err, connectionModel) => {
+        Connection.from(dbUri, (err, connectionModel) => {
           if (err) {
             return reject(err);
           }

src/test/suite/connectionController.test.ts

@@ -240,7 +240,7 @@ suite('Collection Documents Provider Test Suite', () => {
     ): void => {
       assert(mockShowMessage.called);
       assert(!mockHideMessage.called);
-      assert(mockShowMessage.firstArg === 'Fetching documents...');
+      assert(mockShowMessage.firstCall.args[0] === 'Fetching documents...');
 
       return callback(null, ['aaaaaaaaaaaaaaaaa']);
     };

src/test/suite/editors/collectionDocumentsProvider.test.ts

@@ -191,7 +191,7 @@ suite('Document Provider Test Suite', () => {
     ): void => {
       assert(mockShowMessage.called);
       assert(!mockHideMessage.called);
-      assert(mockShowMessage.firstArg === 'Fetching document...');
+      assert(mockShowMessage.firstCall.args[0] === 'Fetching document...');
 
       return callback(null, [{ b: 'aaaaaaaaaaaaaaaaa' }]);
     };

src/test/suite/editors/documentProvider.test.ts

@@ -346,7 +346,7 @@ suite('Explorer Controller Test Suite', function () {
 
     testExplorerController.activateTreeView();
 
-    const treeControllerStub = sinon.stub().returns();
+    const treeControllerStub = sinon.stub().returns(null);
 
     sinon.replace(
       testExplorerController.getTreeController(),

src/test/suite/explorer/explorerController.test.ts

@@ -156,8 +156,8 @@ suite('SchemaTreeItem Test Suite', () => {
         const expectedMessage =
           'Unable to parse schema: Unknown input type for `docs`. Must be an array, stream or MongoDB Cursor.';
         assert(
-          fakeVscodeErrorMessage.firstArg === expectedMessage,
-          `Expected error message to be "${expectedMessage}" found "${fakeVscodeErrorMessage.firstArg}"`
+          fakeVscodeErrorMessage.firstCall.args[0] === expectedMessage,
+          `Expected error message to be "${expectedMessage}" found "${fakeVscodeErrorMessage.firstCall.args[0]}"`
         );
       })
       .then(done, done);