Make mongosh the default shell (#306)

* Make `mongosh` the default shell

* Updated shell tests

Co-authored-by: Massimiliano Marcon <[email protected]>

Author: mmarcon

README.md

@@ -41,7 +41,7 @@ Launch the MongoDB Shell from the command palette to quickly connect to the same
 
 ![MongoDB Shell](resources/screenshots/shell-launcher.png)
 
-_The shell binary needs to be in your `$PATH`. The shell binary can be either the `mongo` shell or the new [MongoDB Shell](https://www.mongodb.com/products/shell) (`mongosh`). In the extension's settings you can switch between the two._
+_The shell binary needs to be in your `$PATH`. The shell binary can be either the new [MongoDB Shell](https://www.mongodb.com/products/shell) (`mongosh`) or the legacy `mongo` shell. In the extension's settings you can switch between the two._
 
 ### Terraform snippet for MongoDB Atlas
 
@@ -51,7 +51,7 @@ If you use Terraform to manage your infrastructure, MongoDB for VS Code helps yo
 
 ## Extension Settings
 
-- `mdb.shell`: The MongoDB shell to use (`mongo` or the new `mongosh`).
+- `mdb.shell`: The MongoDB shell to use (The new `mongosh` or the legacy `mongo`).
 - `mdb.show`: Show or hide the MongoDB view.
 - `mdb.defaultLimit`: The number of documents to fetch when viewing documents from a collection.
 - `mdb.confirmRunAll`: Show a confirmation message before running commands in a playground.

package.json

@@ -767,14 +767,14 @@
         "mdb.shell": {
           "type": "string",
           "enum": [
-            "mongo",
-            "mongosh"
+            "mongosh",
+            "mongo"
           ],
           "enumDescriptions": [
-            "Use the legacy mongo shell",
-            "Use the new mongosh"
+            "Use the new mongosh",
+            "Use the legacy mongo shell"
           ],
-          "default": "mongo",
+          "default": "mongosh",
           "description": "The MongoDB shell to use."
         },
         "mdb.showMongoDBConnectionExplorer": {

src/test/suite/commands/launchMongoShell.test.ts

@@ -38,7 +38,7 @@ suite('Commands Test Suite', () => {
 
     createTerminalStub.returns({
       sendText: fakeSendTerminalText,
-      show: () => {}
+      show: () => { }
     });
     sandbox.replace(vscode.window, 'createTerminal', createTerminalStub);
   });
@@ -95,7 +95,7 @@ suite('Commands Test Suite', () => {
 
       const shellCommandText = fakeSendTerminalText.firstCall.args[0];
 
-      assert.strictEqual(shellCommandText, 'mongo $MDB_CONNECTION_STRING;');
+      assert.strictEqual(shellCommandText, 'mongosh $MDB_CONNECTION_STRING;');
     });
 
     test('openMongoDBShell should open a terminal with ssh tunnel port injected', async () => {
@@ -123,7 +123,7 @@ suite('Commands Test Suite', () => {
 
       const shellCommandText = fakeSendTerminalText.firstCall.args[0];
 
-      assert.strictEqual(shellCommandText, 'mongo $MDB_CONNECTION_STRING;');
+      assert.strictEqual(shellCommandText, 'mongosh $MDB_CONNECTION_STRING;');
     });
 
     test('openMongoDBShell should open a terminal with ssl config injected', async () => {
@@ -154,7 +154,7 @@ suite('Commands Test Suite', () => {
 
       const shellCommandText = fakeSendTerminalText.firstCall.args[0];
 
-      assert.strictEqual(shellCommandText, 'mongo --tls --tlsAllowInvalidHostnames --tlsCAFile="./path_to_some_file" $MDB_CONNECTION_STRING;');
+      assert.strictEqual(shellCommandText, 'mongosh --tls --tlsAllowInvalidHostnames --tlsCAFile="./path_to_some_file" $MDB_CONNECTION_STRING;');
     });
 
     test('openMongoDBShell should open a terminal with x509 config injected', async () => {
@@ -184,7 +184,7 @@ suite('Commands Test Suite', () => {
 
       const shellCommandText = fakeSendTerminalText.firstCall.args[0];
 
-      assert.strictEqual(shellCommandText, 'mongo --tls --tlsAllowInvalidHostnames --tlsCAFile="./path_to_ca" --tlsCertificateKeyFile="./path_to_cert" $MDB_CONNECTION_STRING;');
+      assert.strictEqual(shellCommandText, 'mongosh --tls --tlsAllowInvalidHostnames --tlsCAFile="./path_to_ca" --tlsCertificateKeyFile="./path_to_cert" $MDB_CONNECTION_STRING;');
     });
   });
 
@@ -247,9 +247,9 @@ suite('Commands Test Suite', () => {
         terminalOptions.env?.MDB_CONNECTION_STRING?.includes(
           'mongodb://127.0.0.1'
         ) &&
-          terminalOptions.env?.MDB_CONNECTION_STRING.includes(
-            '/?readPreference=primary&ssl=false'
-          ),
+        terminalOptions.env?.MDB_CONNECTION_STRING.includes(
+          '/?readPreference=primary&ssl=false'
+        ),
         `Expected open terminal to set shell arg as driver url with ssh tunnel port injected found "${terminalOptions.env?.MDB_CONNECTION_STRING}"`
       );
     });
@@ -349,9 +349,9 @@ suite('Commands Test Suite', () => {
         terminalOptions.env?.MDB_CONNECTION_STRING?.includes(
           'mongodb://127.0.0.1'
         ) &&
-          terminalOptions.env?.MDB_CONNECTION_STRING.includes(
-            '/?readPreference=primary&ssl=false'
-          ),
+        terminalOptions.env?.MDB_CONNECTION_STRING.includes(
+          '/?readPreference=primary&ssl=false'
+        ),
         `Expected open terminal to set shell arg as driver url with ssh tunnel port injected found "${terminalOptions.env?.MDB_CONNECTION_STRING}"`
       );
     });