comments

Author: baileympearson

etc/install-zstd.sh

@@ -14,7 +14,7 @@ download_zstd() {
 }
 
 build_zstd() {
-	export MACOSX_DEPLOYMENT_TARGET=10.12
+	export MACOSX_DEPLOYMENT_TARGET=11
 	cd deps/zstd/build/cmake
 
 	cmake .

lib/index.js

@@ -1,15 +1,17 @@
 'use strict';
 const zstd = require('bindings')('zstd');
 const { promisify } = require('util');
+const { isArrayBufferView } = require('util/types');
 
 const _compress = promisify(zstd.compress);
 const _decompress = promisify(zstd.decompress);
 // Error objects created via napi don't have JS stacks; wrap them so .stack is present
 // https://github.com/nodejs/node/issues/25318#issuecomment-451068073
 
 exports.compress = async function compress(data, compressionLevel) {
-  if (!Buffer.isBuffer(data)) {
-    throw new TypeError(`parameter 'data' must be a Buffer.`);
+  const isUint8Array = isArrayBufferView(data) && data instanceof Uint8Array;
+  if (!isUint8Array) {
+    throw new TypeError(`parameter 'data' must be a Uint8Array.`);
   }
 
   if (compressionLevel != null && typeof compressionLevel !== 'number') {
@@ -23,8 +25,9 @@ exports.compress = async function compress(data, compressionLevel) {
   }
 };
 exports.decompress = async function decompress(data) {
-  if (!Buffer.isBuffer(data)) {
-    throw new TypeError(`parameter 'data' must be a Buffer.`);
+  const isUint8Array = isArrayBufferView(data) && data instanceof Uint8Array;
+  if (!isUint8Array) {
+    throw new TypeError(`parameter 'data' must be a Uint8Array.`);
   }
   try {
     return await _decompress(data);

test/index.test.js

@@ -1,4 +1,4 @@
-const { describe, test } = require('mocha');
+const { test } = require('mocha');
 const { compress, decompress } = require('../lib/index');
 
 const zstdLegacy = require('@mongodb-js/zstd');
@@ -14,7 +14,7 @@ describe('decompress', function () {
   test('decompress() throws a TypeError', async function () {
     expect(await decompress().catch(e => e))
       .to.be.instanceOf(TypeError)
-      .to.match(/must be a buffer/i);
+      .to.match(/must be a uint8array/i);
   });
 
   test('decompress() returns a Nodejs buffer', async function () {
@@ -27,7 +27,7 @@ describe('compress', function () {
   test('compress() throws a TypeError', async function () {
     expect(await compress().catch(e => e))
       .to.be.instanceOf(TypeError)
-      .to.match(/must be a buffer/i);
+      .to.match(/must be a uint8array/i);
   });
 
   test('compress() returns a Nodejs buffer', async function () {