fix(NODE-7227): build glibc prebuilds on platforms with libc 2.28 #93
Conversation
|
|
||
| RUN apt-get -qq update | ||
| RUN apt-get -qq install -y python3 build-essential curl cmake | ||
| RUN yum install -y python39 git make curl cmake gcc-toolset-14 |
There was a problem hiding this comment.
Durran added support for Node24 while working on #80. Node24 requires C++20. However, the gcc-c++ package I installed in FLE and Kerberos uses g++ 8.5, which does not support c++20 with the --g++20 flag, breaking compilation.
gcc-toolset-14 installs g++14, which supports officially c++20. We'll have to make this change in FLE and kerberos when we add support for Node24 after v7 too.
| --build-arg="RUN_TEST=true" \ | ||
| --output type=local,dest=./prebuilds,platform-split=false \ | ||
| -f ./.github/docker/Dockerfile.glibc \ | ||
| -f ./.github/docker/Dockerfile.glibc -t glibc-zstd-base \ |
There was a problem hiding this comment.
Just a nice-to-have. Specifying a tag means you can load this locally without rebuilding the image if you need to debug locally:
> docker run -it glibc-zstd-base
| 'cflags!': [ '-fno-exceptions' ], | ||
| 'cflags_cc!': [ '-fno-exceptions' ], | ||
| 'cflags_cc': ['-std=c++17'], | ||
| 'cflags_cc': [], |
There was a problem hiding this comment.
No longer necessary - Node20 uses c++ 17+ too
(question for @addaleax - is there a place where this is officially documented? best I can find is c++ standard specifications in v20.x/common.gypi)
durran
added
the
Primary Review
Description
Summary of Changes
Notes for Reviewers
What is the motivation for this change?
Release Highlight
Release notes highlight
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript