group num_shard tests

Author: lantoli

internal/convert/testdata/adv2v2/errors.json

@@ -1,6 +1,5 @@
 {
 	"configuration_file_error": "failed to parse Terraform config file",
 	"replication_specs_missing_region_configs": "replication_specs must have at least one region_configs",
-	"missing_replication_specs": "must have at least one replication_specs",
-	"num_shards_not_numerical": "setting num_shards: failed to evaluate number"
+	"missing_replication_specs": "must have at least one replication_specs"
 }

internal/convert/testdata/adv2v2/num_shards.in.tf

@@ -1,4 +1,4 @@
-resource "mongodbatlas_advanced_cluster" "geo" {
+resource "mongodbatlas_advanced_cluster" "numerical_num_shards" {
   project_id   = var.project_id
   name         = "geo"
   cluster_type = "GEOSHARDED"
@@ -39,7 +39,7 @@ resource "mongodbatlas_advanced_cluster" "geo" {
   }
 }
 
-resource "mongodbatlas_advanced_cluster" "geo" {
+resource "mongodbatlas_advanced_cluster" "numerical_num_shards_and_disk_size_gb" {
   project_id   = var.project_id
   name         = "geo"
   cluster_type = "GEOSHARDED"
@@ -58,3 +58,22 @@ resource "mongodbatlas_advanced_cluster" "geo" {
     }
   }
 }
+
+resource "mongodbatlas_advanced_cluster" "variable_num_shards" {
+  project_id   = var.project_id
+  name         = "geo"
+  cluster_type = "GEOSHARDED"
+  replication_specs {
+    zone_name  = "Zone 1"
+    num_shards = var.num_shards # unresolved num_shards
+    region_configs {
+      provider_name = "AWS"
+      region_name   = "US_EAST_1"
+      priority      = 7
+      electable_specs {
+        node_count    = 3
+        instance_size = "M10"
+      }
+    }
+  }
+}

internal/convert/testdata/adv2v2/num_shards.out.tf

@@ -1,4 +1,4 @@
-resource "mongodbatlas_advanced_cluster" "geo" {
+resource "mongodbatlas_advanced_cluster" "numerical_num_shards" {
   project_id   = var.project_id
   name         = "geo"
   cluster_type = "GEOSHARDED"
@@ -105,7 +105,7 @@ resource "mongodbatlas_advanced_cluster" "geo" {
   # Updated by atlas-cli-plugin-terraform, please review the changes.
 }
 
-resource "mongodbatlas_advanced_cluster" "geo" {
+resource "mongodbatlas_advanced_cluster" "numerical_num_shards_and_disk_size_gb" {
   project_id   = var.project_id
   name         = "geo"
   cluster_type = "GEOSHARDED"
@@ -144,3 +144,27 @@ resource "mongodbatlas_advanced_cluster" "geo" {
 
   # Updated by atlas-cli-plugin-terraform, please review the changes.
 }
+
+resource "mongodbatlas_advanced_cluster" "variable_num_shards" {
+  project_id   = var.project_id
+  name         = "geo"
+  cluster_type = "GEOSHARDED"
+  replication_specs = [
+    for i in range(var.num_shards) : {
+      zone_name = "Zone 1"
+      region_configs = [
+        {
+          provider_name = "AWS"
+          region_name   = "US_EAST_1"
+          priority      = 7
+          electable_specs = {
+            node_count    = 3
+            instance_size = "M10"
+          }
+        }
+      ]
+    }
+  ]
+
+  # Updated by atlas-cli-plugin-terraform, please review the changes.
+}