create new command adv2new

Author: lantoli

cmd/plugin/main.go

@@ -4,6 +4,7 @@ import (
 	"fmt"
 	"os"
 
+	"github.com/mongodb-labs/atlas-cli-plugin-terraform/internal/cli/adv2new"
 	"github.com/mongodb-labs/atlas-cli-plugin-terraform/internal/cli/clu2adv"
 	"github.com/spf13/cobra"
 )
@@ -15,6 +16,7 @@ func main() {
 		Aliases: []string{"tf"},
 	}
 	terraformCmd.AddCommand(clu2adv.Builder())
+	terraformCmd.AddCommand(adv2new.Builder())
 
 	completionOption := &cobra.CompletionOptions{
 		DisableDefaultCmd:   true,

internal/cli/adv2new/adv2new.go

@@ -0,0 +1,33 @@
+package adv2new
+
+import (
+	"github.com/mongodb-labs/atlas-cli-plugin-terraform/internal/flag"
+	"github.com/spf13/afero"
+	"github.com/spf13/cobra"
+)
+
+func Builder() *cobra.Command {
+	o := &opts{fs: afero.NewOsFs()}
+	cmd := &cobra.Command{
+		Use:   "advancedClusterToNew",
+		Short: "Convert advanced_cluster from provider version 1 to 2",
+		Long: "Convert a Terraform configuration from mongodbatlas_advanced_cluster in provider version 1.X.X (SDKv2)" +
+			" to version 2.X.X (TPF - Terraform Plugin Framework)",
+		Aliases: []string{"adv2new"},
+		RunE: func(_ *cobra.Command, _ []string) error {
+			if err := o.PreRun(); err != nil {
+				return err
+			}
+			return o.Run()
+		},
+	}
+	cmd.Flags().StringVarP(&o.file, flag.File, flag.FileShort, "", "input file")
+	_ = cmd.MarkFlagRequired(flag.File)
+	cmd.Flags().StringVarP(&o.output, flag.Output, flag.OutputShort, "", "output file")
+	_ = cmd.MarkFlagRequired(flag.Output)
+	cmd.Flags().BoolVarP(&o.replaceOutput, flag.ReplaceOutput, flag.ReplaceOutputShort, false,
+		"replace output file if exists")
+	cmd.Flags().BoolVarP(&o.watch, flag.Watch, flag.WatchShort, false,
+		"keeps the plugin running and watches the input file for changes")
+	return cmd
+}

internal/cli/adv2new/opts.go

@@ -0,0 +1,96 @@
+package adv2new
+
+import (
+	"errors"
+	"fmt"
+
+	"github.com/fsnotify/fsnotify"
+	"github.com/mongodb-labs/atlas-cli-plugin-terraform/internal/convert"
+	"github.com/mongodb-labs/atlas-cli-plugin-terraform/internal/file"
+	"github.com/spf13/afero"
+)
+
+type opts struct {
+	fs            afero.Fs
+	file          string
+	output        string
+	replaceOutput bool
+	watch         bool
+}
+
+func (o *opts) PreRun() error {
+	if err := file.MustExist(o.fs, o.file); err != nil {
+		return err
+	}
+	if !o.replaceOutput {
+		return file.MustNotExist(o.fs, o.output)
+	}
+	return nil
+}
+
+func (o *opts) Run() error {
+	if err := o.generateFile(false); err != nil {
+		return err
+	}
+	if o.watch {
+		return o.watchFile()
+	}
+	return nil
+}
+
+func (o *opts) generateFile(allowParseErrors bool) error {
+	inConfig, err := afero.ReadFile(o.fs, o.file)
+	if err != nil {
+		return fmt.Errorf("failed to read file %s: %w", o.file, err)
+	}
+	outConfig, err := convert.AdvancedClusterToNew(inConfig)
+	if err != nil {
+		if allowParseErrors {
+			outConfig = []byte("# CONVERT ERROR: " + err.Error() + "\n\n")
+			outConfig = append(outConfig, inConfig...)
+		} else {
+			return err
+		}
+	}
+	if err := afero.WriteFile(o.fs, o.output, outConfig, 0o600); err != nil {
+		return fmt.Errorf("failed to write file %s: %w", o.output, err)
+	}
+	return nil
+}
+
+func (o *opts) watchFile() error {
+	watcher, err := fsnotify.NewWatcher()
+	if err != nil {
+		return nil
+	}
+	defer watcher.Close()
+	if err := watcher.Add(o.file); err != nil {
+		return err
+	}
+	for {
+		if err := o.waitForFileEvent(watcher); err != nil {
+			return err
+		}
+	}
+}
+
+func (o *opts) waitForFileEvent(watcher *fsnotify.Watcher) error {
+	watcherError := errors.New("watcher has been closed")
+	select {
+	case event, ok := <-watcher.Events:
+		if !ok {
+			return watcherError
+		}
+		if event.Has(fsnotify.Write) {
+			if err := o.generateFile(true); err != nil {
+				return err
+			}
+		}
+	case err, ok := <-watcher.Errors:
+		if !ok {
+			return watcherError
+		}
+		return err
+	}
+	return nil
+}

internal/convert/adv2new.go

@@ -0,0 +1,8 @@
+package convert
+
+// AdvancedClusterToNew transforms all mongodbatlas_advanced_cluster resource definitions in a
+// Terraform configuration file from SDKv2 schema to TPF (Terraform Plugin Framework) schema.
+// All other resources and data sources are left untouched.
+func AdvancedClusterToNew(config []byte) ([]byte, error) {
+	return config, nil
+}

internal/convert/adv2new_test.go

@@ -0,0 +1,51 @@
+package convert_test
+
+import (
+	"encoding/json"
+	"path/filepath"
+	"strings"
+	"testing"
+
+	"github.com/mongodb-labs/atlas-cli-plugin-terraform/internal/convert"
+	"github.com/sebdah/goldie/v2"
+	"github.com/spf13/afero"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestAdvancedClusterToNew(t *testing.T) {
+	const (
+		root        = "testdata/adv2new"
+		inSuffix    = ".in.tf"
+		outSuffix   = ".out.tf"
+		errFilename = "errors.json"
+	)
+	fs := afero.NewOsFs()
+	errMap := make(map[string]string)
+	errContent, err := afero.ReadFile(fs, filepath.Join(root, errFilename))
+	require.NoError(t, err)
+	err = json.Unmarshal(errContent, &errMap)
+	require.NoError(t, err)
+	g := goldie.New(t,
+		goldie.WithFixtureDir(root),
+		goldie.WithNameSuffix(outSuffix))
+	pattern := filepath.Join(root, "*"+inSuffix)
+	inputFiles, err := afero.Glob(fs, pattern)
+	require.NoError(t, err)
+	assert.NotEmpty(t, inputFiles)
+	for _, inputFile := range inputFiles {
+		testName := strings.TrimSuffix(filepath.Base(inputFile), inSuffix)
+		t.Run(testName, func(t *testing.T) {
+			inConfig, err := afero.ReadFile(fs, inputFile)
+			require.NoError(t, err)
+			outConfig, err := convert.AdvancedClusterToNew(inConfig)
+			if err == nil {
+				g.Assert(t, testName, outConfig)
+			} else {
+				errMsg, found := errMap[testName]
+				assert.True(t, found, "error not found in file %s for test %s, errMsg: %v", errFilename, testName, err)
+				assert.Contains(t, err.Error(), errMsg)
+			}
+		})
+	}
+}

internal/convert/convert.go renamed to internal/convert/clu2adv.go

@@ -0,0 +1,4 @@
+resource "mongodbatlas_advanced_cluster" "basic" {
+  name = "basic"
+  // TODO: missing fields as transformation is not implemented yet
+}

internal/convert/convert_test.go renamed to internal/convert/clu2adv_test.go

@@ -0,0 +1,4 @@
+resource "mongodbatlas_advanced_cluster" "basic" {
+  name = "basic"
+  // TODO: missing fields as transformation is not implemented yet
+}

internal/convert/testdata/adv2new/basic.in.tf

@@ -0,0 +1 @@
+{}