add error checks

Author: lantoli

internal/hcl/hcl_test.go

@@ -1,6 +1,7 @@
 package hcl_test
 
 import (
+	"encoding/json"
 	"path/filepath"
 	"strings"
 	"testing"
@@ -14,14 +15,20 @@ import (
 
 func TestClusterToAdvancedCluster(t *testing.T) {
 	const (
-		root      = "testdata/clu2adv"
-		inSuffix  = ".in.tf"
-		outSuffix = ".out.tf"
+		root        = "testdata/clu2adv"
+		inSuffix    = ".in.tf"
+		outSuffix   = ".out.tf"
+		errFilename = "errors.json"
 	)
+	fs := afero.NewOsFs()
+	errMap := make(map[string]string)
+	errContent, err := afero.ReadFile(fs, filepath.Join(root, errFilename))
+	require.NoError(t, err)
+	err = json.Unmarshal(errContent, &errMap)
+	require.NoError(t, err)
 	g := goldie.New(t,
 		goldie.WithFixtureDir(root),
 		goldie.WithNameSuffix(outSuffix))
-	fs := afero.NewOsFs()
 	pattern := filepath.Join(root, "*"+inSuffix)
 	inputFiles, err := afero.Glob(fs, pattern)
 	require.NoError(t, err)
@@ -31,7 +38,12 @@ func TestClusterToAdvancedCluster(t *testing.T) {
 		inConfig, err := afero.ReadFile(fs, inputFile)
 		require.NoError(t, err)
 		outConfig, err := hcl.ClusterToAdvancedCluster(inConfig)
-		require.NoError(t, err)
-		g.Assert(t, testName, outConfig)
+		if err == nil {
+			g.Assert(t, testName, outConfig)
+		} else {
+			errMsg, found := errMap[testName]
+			assert.True(t, found, "error not found for test %s", testName)
+			assert.Contains(t, err.Error(), errMsg)
+		}
 	}
 }

internal/hcl/testdata/clu2adv/configuration_file_error.in.tf

@@ -0,0 +1,2 @@
+resource this is an invalid HCL configuration file
+

internal/hcl/testdata/clu2adv/errors.json

@@ -0,0 +1,4 @@
+{
+	"configuration_file_error": "failed to parse Terraform config file",
+	"free_cluster_missing_attribute": "free cluster (because no replication_specs): attribute backing_provider_name not found"
+}

internal/hcl/testdata/clu2adv/free_cluster_missing_attribute.in.tf

@@ -0,0 +1,19 @@
+resource "resource1" "res1" {
+  name = "name1"
+}
+
+resource "mongodbatlas_cluster" "free_cluster" { # comment in the resource
+  # comment in own line in the beginning
+  count                       = local.use_free_cluster ? 1 : 0
+  project_id                  = var.project_id # inline comment kept
+  name                        = var.cluster_name
+  # comment in own line in the middle is deleted
+  provider_name               = "TENANT" # inline comment for attribute moved is not kept
+  provider_region_name        = var.region
+  provider_instance_size_name = "M0"
+  # comment in own line at the end happens before replication_specs
+}
+
+data "mongodbatlas_cluster" "cluster2" {
+  name = "name4"
+}