make name more explicit with processNumShardsWhenSomeIsVariable

Author: lantoli

internal/convert/adv2v2.go

@@ -105,7 +105,7 @@ func convertRepSpecs(resourceb *hclwrite.Body, diskSizeGB hclwrite.Tokens) error
 			blockb.SetAttributeRaw(nConfig, hcl.TokensArray(configs))
 		}
 		if hasVariableShards {
-			resultTokens = append(resultTokens, processNumShards(shardsAttr, blockb))
+			resultTokens = append(resultTokens, processNumShardsWhenSomeIsVariable(shardsAttr, blockb))
 			continue
 		}
 		numShardsVal := 1 // Default to 1 if num_shards is not set

internal/convert/clu2adv.go

@@ -200,7 +200,7 @@ func fillRepSpecs(resourceb *hclwrite.Body, root attrVals) error {
 			return errConfig
 		}
 		if hasVariableShards {
-			resultTokens = append(resultTokens, processNumShards(shardsAttr, specb))
+			resultTokens = append(resultTokens, processNumShardsWhenSomeIsVariable(shardsAttr, specb))
 			continue
 		}
 		shardsVal, err := hcl.GetAttrInt(shardsAttr, errNumShards)

internal/convert/shared.go

@@ -21,9 +21,8 @@ func hasVariableNumShards(blocks []*hclwrite.Block) bool {
 	return false
 }
 
-// processNumShards handles num_shards for a block, returning tokens for the expanded specs.
-// processedBody is the body with num_shards removed and other processing done.
-func processNumShards(shardsAttr *hclwrite.Attribute, processedBody *hclwrite.Body) hclwrite.Tokens {
+// processNumShardsWhenSomeIsVariable handles num_shards when some replication_specs have variable num_shards
+func processNumShardsWhenSomeIsVariable(shardsAttr *hclwrite.Attribute, processedBody *hclwrite.Body) hclwrite.Tokens {
 	if shardsAttr == nil {
 		return hcl.TokensArraySingle(processedBody) // Default 1 if no num_shards specified
 	}
@@ -118,11 +117,9 @@ func collectBlocks(body *hclwrite.Body, name string) []*hclwrite.Block {
 	for _, block := range body.Blocks() {
 		if block.Type() == name {
 			blocks = append(blocks, block)
+			body.RemoveBlock(block)
 		}
 	}
-	for _, block := range blocks {
-		body.RemoveBlock(block)
-	}
 	return blocks
 }