Skip to content

Commit 358797f

Browse files
committed
move out comment examples
1 parent f23bb1d commit 358797f

File tree

5 files changed

+89
-24
lines changed

5 files changed

+89
-24
lines changed

internal/convert/testdata/clu2adv/free_cluster_with_count.in.tf renamed to internal/convert/testdata/clu2adv/comments.in.tf

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
resource "resource1" "res1" {
2-
name = "name1"
3-
}
4-
51
resource "mongodbatlas_cluster" "free_cluster" { # comment in the resource
62
# comment in own line in the beginning
73
count = local.use_free_cluster ? 1 : 0
@@ -14,3 +10,8 @@ resource "mongodbatlas_cluster" "free_cluster" { # comment in the resource
1410
provider_instance_size_name = "M0"
1511
# comment in own line at the end happens before replication_specs
1612
}
13+
14+
resource "another_resource" "res1" {
15+
# comment in own line in the middle is not deleted in unprocessed resource
16+
name = "name1"
17+
}

internal/convert/testdata/clu2adv/free_cluster_with_count.out.tf renamed to internal/convert/testdata/clu2adv/comments.out.tf

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
resource "resource1" "res1" {
2-
name = "name1"
3-
}
4-
51
resource "mongodbatlas_advanced_cluster" "free_cluster" { # comment in the resource
62
# comment in own line in the beginning
73
count = local.use_free_cluster ? 1 : 0
@@ -28,3 +24,8 @@ resource "mongodbatlas_advanced_cluster" "free_cluster" { # comment in the resou
2824
# Generated by atlas-cli-plugin-terraform.
2925
# Please review the changes and confirm that references to this resource are updated.
3026
}
27+
28+
resource "another_resource" "res1" {
29+
# comment in own line in the middle is not deleted in unprocessed resource
30+
name = "name1"
31+
}
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
resource "mongodbatlas_cluster" "free_cluster" {
2+
project_id = var.project_id
3+
name = var.cluster_name
4+
provider_name = "TENANT"
5+
backing_provider_name = "AWS"
6+
provider_region_name = var.region
7+
provider_instance_size_name = "M0"
8+
}
9+
10+
resource "mongodbatlas_cluster" "count" {
11+
count = local.use_free_cluster ? 1 : 0
12+
project_id = var.project_id
13+
name = var.cluster_name
14+
provider_name = "TENANT"
15+
backing_provider_name = "AWS"
16+
provider_region_name = var.region
17+
provider_instance_size_name = "M0"
18+
}
19+
20+
resource "another_resource" "res1" {
21+
name = "name1"
22+
}
Lines changed: 52 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,52 @@
1+
resource "mongodbatlas_advanced_cluster" "free_cluster" {
2+
project_id = var.project_id
3+
name = var.cluster_name
4+
cluster_type = "REPLICASET"
5+
replication_specs = [
6+
{
7+
region_configs = [
8+
{
9+
priority = 7
10+
region_name = var.region
11+
provider_name = "TENANT"
12+
backing_provider_name = "AWS"
13+
electable_specs = {
14+
instance_size = "M0"
15+
}
16+
}
17+
]
18+
}
19+
]
20+
21+
# Generated by atlas-cli-plugin-terraform.
22+
# Please review the changes and confirm that references to this resource are updated.
23+
}
24+
25+
resource "mongodbatlas_advanced_cluster" "count" {
26+
count = local.use_free_cluster ? 1 : 0
27+
project_id = var.project_id
28+
name = var.cluster_name
29+
cluster_type = "REPLICASET"
30+
replication_specs = [
31+
{
32+
region_configs = [
33+
{
34+
priority = 7
35+
region_name = var.region
36+
provider_name = "TENANT"
37+
backing_provider_name = "AWS"
38+
electable_specs = {
39+
instance_size = "M0"
40+
}
41+
}
42+
]
43+
}
44+
]
45+
46+
# Generated by atlas-cli-plugin-terraform.
47+
# Please review the changes and confirm that references to this resource are updated.
48+
}
49+
50+
resource "another_resource" "res1" {
51+
name = "name1"
52+
}
Lines changed: 5 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,8 @@
1-
resource "resource1" "res1" {
2-
name = "name1"
3-
}
4-
5-
resource "mongodbatlas_cluster" "free_cluster" { # comment in the resource
6-
# comment in own line in the beginning
7-
count = local.use_free_cluster ? 1 : 0
8-
project_id = var.project_id # inline comment kept
9-
name = var.cluster_name
10-
# comment in own line in the middle is deleted
11-
provider_name = "TENANT" # inline comment for attribute moved is not kept
1+
resource "mongodbatlas_cluster" "free_cluster" {
2+
project_id = var.project_id
3+
name = var.cluster_name
4+
provider_name = "TENANT"
125
provider_region_name = var.region
136
provider_instance_size_name = "M0"
14-
# comment in own line at the end happens before replication_specs
15-
}
16-
17-
data "mongodbatlas_cluster" "cluster2" {
18-
name = "name4"
7+
# missing backing_provider_name
198
}

0 commit comments

Comments
 (0)