basic tags

Author: lantoli

README.md

@@ -36,7 +36,7 @@ If you want to overwrite the output file if it exists, or even use the same outp
 - The plugin doesn't support `regions_config` without `electable_nodes` as there can be some issues with `priority` when they only have `analytics_nodes` and/or `electable_nodes`.
 - `priority` is required in `regions_config` and must be a resolved number between 7 and 1, e.g. `var.priority` is not supported. This is to allow reordering them by descending priority as this is expected in `mongodbatlas_advanced_cluster`.
 - `dynamic` blocks to generate `replication_specs`, `regions_config`, etc. are not supported.
-
+- `key` value in `tags` or `labels` must be a resolved string because it will be the key in the map in `mongodb_atlas_advanced_cluster`, e.g. `key = var.tag_key` is not supported.
 
 ## Contributing
 

internal/convert/const_names.go

@@ -4,6 +4,9 @@ const (
 	nRepSpecs                   = "replication_specs"
 	nConfig                     = "region_configs"
 	nConfigSrc                  = "regions_config"
+	nTags                       = "tags"
+	nLabels                     = "labels"
+	nTimeouts                   = "timeouts"
 	nElectableSpecs             = "electable_specs"
 	nAutoScaling                = "auto_scaling"
 	nReadOnlySpecs              = "read_only_specs"
@@ -38,4 +41,6 @@ const (
 	nElectableNodes             = "electable_nodes"
 	nReadOnlyNodes              = "read_only_nodes"
 	nAnalyticsNodes             = "analytics_nodes"
+	nKey                        = "key"
+	nValue                      = "value"
 )

internal/convert/convert.go

@@ -115,8 +115,15 @@ func fillReplicationSpecs(resourceb *hclwrite.Body) error {
 	}
 	repSpecs := hclwrite.NewEmptyFile()
 	repSpecs.Body().SetAttributeRaw(nConfig, configs)
-
 	resourceb.SetAttributeRaw(nRepSpecs, hcl.TokensArraySingle(repSpecs))
+	tags, errTags := getTagsLabelsOpt(nTags, resourceb)
+	if errTags != nil {
+		return errTags
+	}
+	if tags != nil {
+		resourceb.SetAttributeRaw(nTags, tags)
+	}
+
 	resourceb.RemoveBlock(repSpecsSrc)
 	return nil
 }
@@ -224,6 +231,36 @@ func getAutoScalingOpt(opt map[string]hclwrite.Tokens) hclwrite.Tokens {
 	return hcl.TokensObject(file)
 }
 
+func getTagsLabelsOpt(attrName string, resourceb *hclwrite.Body) (hclwrite.Tokens, error) {
+	var (
+		file  = hclwrite.NewEmptyFile()
+		fileb = file.Body()
+		found = false
+	)
+	for {
+		block := resourceb.FirstMatchingBlock(attrName, nil)
+		if block == nil {
+			break
+		}
+		key := block.Body().GetAttribute(nKey)
+		value := block.Body().GetAttribute(nValue)
+		if key == nil || value == nil {
+			return nil, fmt.Errorf("%s: %s or %s not found", attrName, nKey, nValue)
+		}
+		keyStr, err := hcl.GetAttrString(key, "unresolved key in "+attrName)
+		if err != nil {
+			return nil, err
+		}
+		fileb.SetAttributeRaw(keyStr, value.Expr().BuildTokens(nil))
+		resourceb.RemoveBlock(block)
+		found = true
+	}
+	if !found {
+		return nil, nil
+	}
+	return hcl.TokensObject(file), nil
+}
+
 func checkDynamicBlock(body *hclwrite.Body) error {
 	for _, block := range body.Blocks() {
 		if block.Type() == "dynamic" {

internal/convert/testdata/clu2adv/errors.json

@@ -8,5 +8,6 @@
 	"regions_config_out_of_range_priority": "setting priority: priority is 0 but must be between 1 and 7",
 	"regions_config_unresolved_priority": "setting priority: failed to evaluate number",
 	"replication_specs_unsupported_dynamic": "dynamic blocks are not supported",
-	"regions_config_unsupported_dynamic": "dynamic blocks are not supported"
+	"regions_config_unsupported_dynamic": "dynamic blocks are not supported",
+	"tags_unresolved_key": "unresolved key in tags"
 }

internal/convert/testdata/clu2adv/tags_labels_timeouts.in.tf

@@ -0,0 +1,19 @@
+resource "mongodbatlas_cluster" "basictags" {
+  project_id                  = var.project_id
+  name                        = "basictags"
+  cluster_type                = "REPLICASET"
+  provider_name               = "AWS"
+  provider_instance_size_name = "M10"
+  replication_specs {
+    num_shards = 1
+    regions_config {
+      region_name     = "US_EAST_1"
+      electable_nodes = 3
+      priority        = 7
+    }
+  }
+  tags {
+    key   = "environment"
+    value = "dev"
+  }
+}

internal/convert/testdata/clu2adv/tags_labels_timeouts.out.tf

@@ -0,0 +1,22 @@
+resource "mongodbatlas_advanced_cluster" "basictags" {
+  project_id   = var.project_id
+  name         = "basictags"
+  cluster_type = "REPLICASET"
+  replication_specs = [{
+    region_configs = [{
+      provider_name = "AWS"
+      region_name   = "US_EAST_1"
+      priority      = 7
+      electable_specs = {
+        node_count    = 3
+        instance_size = "M10"
+      }
+    }]
+  }]
+  tags = {
+    environment = "dev"
+  }
+
+  # Generated by atlas-cli-plugin-terraform.
+  # Please confirm that all references to this resource are updated.
+}

internal/convert/testdata/clu2adv/tags_unresolved_key.in.tf

@@ -0,0 +1,20 @@
+resource "mongodbatlas_cluster" "basictags" {
+  project_id                  = var.project_id
+  name                        = "basictags"
+  cluster_type                = "REPLICASET"
+  provider_name               = "AWS"
+  provider_instance_size_name = "M10"
+  replication_specs {
+    num_shards = 1
+    regions_config {
+      region_name     = "US_EAST_1"
+      electable_nodes = 3
+      priority        = 7
+    }
+  }
+  tags {
+    # key must be a resolved string because it will be the key in the advanced_cluster map
+    key   = var.env
+    value = "dev"
+  }
+}

internal/hcl/hcl.go

@@ -55,6 +55,22 @@ func GetAttrInt(attr *hclwrite.Attribute, errPrefix string) (int, error) {
 	return int(num), nil
 }
 
+// GetAttrString tries to get an attribute value as a string.
+func GetAttrString(attr *hclwrite.Attribute, errPrefix string) (string, error) {
+	expr, diags := hclsyntax.ParseExpression(attr.Expr().BuildTokens(nil).Bytes(), "", hcl.InitialPos)
+	if diags.HasErrors() {
+		return "", fmt.Errorf("%s: failed to parse string: %s", errPrefix, diags.Error())
+	}
+	val, diags := expr.Value(nil)
+	if diags.HasErrors() {
+		return "", fmt.Errorf("%s: failed to evaluate string: %s", errPrefix, diags.Error())
+	}
+	if !val.Type().Equals(cty.String) {
+		return "", fmt.Errorf("%s: attribute is not a string", errPrefix)
+	}
+	return val.AsString(), nil
+}
+
 // TokensArray creates an array of objects.
 func TokensArray(file []*hclwrite.File) hclwrite.Tokens {
 	ret := hclwrite.Tokens{