Skip to content

Commit 3f5d2b2

Browse files
committed
apply feedback
1 parent 2c6afef commit 3f5d2b2

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

docs/command_adv2v2.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ We recommend reviewing the output and making sure it fits your needs.
3737

3838
### Dynamic blocks in tags and labels
3939

40-
You can use `dynamic` blocks for `tags` and `labels`. The plugin assumes that `for_each` has an expression which is evaluated to a `map` of strings.
41-
You can also combine the use of dynamic blocks in `tags` and `labels` with individual blocks in the same cluster definition, e.g.:
40+
You can use `dynamic` blocks for `tags` and `labels`. The plugin assumes that the value of `for_each` is an expression which evaluates to a `map` of strings.
41+
You can also combine the use of dynamic blocks in `tags` and `labels` with individual blocks in the same cluster definition, for example:
4242
```hcl
4343
tags {
4444
key = "environment"
@@ -80,7 +80,7 @@ replication_specs {
8080

8181
### Dynamic blocks in replication_specs
8282

83-
You can use `dynamic` blocks for `replication_specs`. The plugin assumes that `for_each` has an expression which is evaluated to a `list` of objects.
83+
You can use `dynamic` blocks for `replication_specs`. The plugin assumes that the value of `for_each` is an expression which evaluates to a `list` of objects.
8484

8585
This is an example of how to use dynamic blocks in `replication_specs`:
8686
```hcl
@@ -112,7 +112,7 @@ If you need to use the plugin for `dynamic` block use cases not yet supported, p
112112

113113
Dynamic blocks and individual blocks for `region_configs` or `replication_specs` are not supported at the same time. Remove the individual `region_configs` or `replication_specs` blocks and use a local `list` variable with [concat](https://developer.hashicorp.com/terraform/language/functions/concat) to add the individual block information to the variable you're using in the `for_each` expression.
114114

115-
Let's see an example with `region_configs`; it is the same idea for `replication_specs`. In the original configuration file, the `mongodb_cluster` resource is used inside a module that receives the `region_configs` elements in a `list` variable and we want to add an additional `region_configs` with a read-only node.
115+
Let's see an example with `region_configs`; it's the same idea for `replication_specs`. In the original configuration file, the `mongodb_cluster` resource is used inside a module that receives the `region_configs` elements in a `list` variable and we want to add an additional `region_configs` with a read-only node.
116116
```hcl
117117
variable "replication_specs" {
118118
type = object({

docs/command_clu2adv.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ If you want to convert a Terraform configuration from `mongodbatlas_cluster` to
1313
atlas terraform clusterToAdvancedCluster --file in.tf --output out.tf
1414
```
1515

16-
you can also use shorter aliases, e.g.:
16+
You can also use shorter aliases, for example:
1717
```bash
1818
atlas tf clu2adv -f in.tf -o out.tf
1919
```
@@ -38,7 +38,7 @@ We recommend reviewing the output and making sure it fits your needs.
3838
### Dynamic blocks in tags and labels
3939

4040
You can use `dynamic` blocks for `tags` and `labels`. The plugin assumes that the value of `for_each` is an expression which evaluates to a `map` of strings.
41-
You can also combine the use of dynamic blocks in `tags` and `labels` with individual blocks in the same cluster definition, e.g.:
41+
You can also combine the use of dynamic blocks in `tags` and `labels` with individual blocks in the same cluster definition, for exaple:
4242
```hcl
4343
tags {
4444
key = "environment"
@@ -55,7 +55,7 @@ dynamic "tags" {
5555

5656
### Dynamic blocks in regions_config
5757

58-
You can use `dynamic` blocks for `regions_config`. The plugin assumes that `for_each` has an expression which is evaluated to a `list` of objects.
58+
You can use `dynamic` blocks for `regions_config`. The plugin assumes that the value of `for_each` is an expression which evaluates to a `list` of objects.
5959

6060
This is an example of how to use dynamic blocks in `regions_config`:
6161
```hcl
@@ -106,7 +106,7 @@ If you need to use the plugin for `dynamic` block use cases not yet supported, p
106106

107107
Dynamic blocks and individual blocks for `regions_config` or `replication_specs` are not supported at the same time. Remove the individual `regions_config` or `replication_specs` blocks and use a local `list` variable with [concat](https://developer.hashicorp.com/terraform/language/functions/concat) to add the individual block information to the variable you're using in the `for_each` expression.
108108

109-
Let's see an example with `regions_config`, it is the same idea for `replication_specs`. In the original configuration file, the `mongodb_cluster` resource is used inside a module that receives the `regions_config` elements in a `list` variable and we want to add an additional `regions_config` with a read-only node.
109+
Let's see an example with `regions_config`, it's the same idea for `replication_specs`. In the original configuration file, the `mongodb_cluster` resource is used inside a module that receives the `regions_config` elements in a `list` variable and we want to add an additional `regions_config` with a read-only node.
110110
```hcl
111111
variable "replication_specs" {
112112
type = object({
@@ -193,4 +193,4 @@ resource "mongodbatlas_cluster" "this" {
193193
}
194194
}
195195
```
196-
This modified configuration file has the same behavior as the original one, but it doesn't have individual blocks anymore, only the `dynamic` block, so it is supported by the plugin.
196+
This modified configuration file has the same behavior as the original one, but it doesn't have individual blocks anymore, only the `dynamic` block, so it's supported by the plugin.

0 commit comments

Comments
 (0)