remove limitations for priority and electable_nodes

Author: lantoli

README.md

@@ -80,8 +80,6 @@ Dynamic block and individual blocks for `regions_config` are not supported at th
 
 ### Limitations
 
-- The plugin doesn't support `regions_config` without `electable_nodes` as there can be some issues with `priority` when they only have `analytics_nodes` and/or `electable_nodes`.
-- [`priority`](https://registry.terraform.io/providers/mongodb/mongodbatlas/latest/docs/resources/cluster#priority-1) is required in `regions_config` and must be a numeric [literal expression](https://developer.hashicorp.com/nomad/docs/job-specification/hcl2/expressions#literal-expressions) between 7 and 1, e.g. `var.priority` is not supported. This is to allow reordering them by descending priority as this is expected in `mongodbatlas_advanced_cluster`.
 - [`num_shards`](https://registry.terraform.io/providers/mongodb/mongodbatlas/latest/docs/resources/cluster#num_shards-2) in `replication_specs` must be a numeric [literal expression](https://developer.hashicorp.com/nomad/docs/job-specification/hcl2/expressions#literal-expressions), e.g. `var.num_shards` is not supported. This is to allow creating a `replication_specs` element per shard in `mongodbatlas_advanced_cluster`.
 - `dynamic` blocks are currently supported only for `tags`, `labels` and `regions_config`. **Coming soon**: support for `replication_specs`.
 

internal/convert/convert.go

@@ -368,11 +368,9 @@ func getRegionConfig(configSrc *hclwrite.Block, root attrVals) (*hclwrite.File,
 	if err := hcl.MoveAttr(configSrc.Body(), fileb, nPriority, nPriority, errRepSpecs); err != nil {
 		return nil, err
 	}
-	electable, errElec := getSpecs(configSrc, nElectableNodes, root)
-	if errElec != nil {
-		return nil, errElec
+	if electable, _ := getSpecs(configSrc, nElectableNodes, root); electable != nil {
+		fileb.SetAttributeRaw(nElectableSpecs, electable)
 	}
-	fileb.SetAttributeRaw(nElectableSpecs, electable)
 	if readOnly, _ := getSpecs(configSrc, nReadOnlyNodes, root); readOnly != nil {
 		fileb.SetAttributeRaw(nReadOnlySpecs, readOnly)
 	}

internal/convert/testdata/clu2adv/analytics_read_only_all_params.in.tf

@@ -18,3 +18,24 @@ resource "mongodbatlas_cluster" "ar" {
     }
   }
 }
+
+resource "mongodbatlas_cluster" "ar_not_electable" {
+  project_id                  = var.project_id
+  name                        = "ar"
+  cluster_type                = "REPLICASET"
+  provider_name               = "AWS"
+  provider_instance_size_name = "M10"
+  disk_size_gb                = 90
+  provider_volume_type        = "PROVISIONED"
+  provider_disk_iops          = 100
+  replication_specs {
+    num_shards = 1
+    regions_config {
+      region_name     = "US_EAST_1"
+      priority        = 7
+      electable_nodes = 0
+      analytics_nodes = 2
+      read_only_nodes = 1
+    }
+  }
+}

internal/convert/testdata/clu2adv/analytics_read_only_all_params.out.tf

@@ -38,3 +38,37 @@ resource "mongodbatlas_advanced_cluster" "ar" {
   # Generated by atlas-cli-plugin-terraform.
   # Please review the changes and confirm that references to this resource are updated.
 }
+
+resource "mongodbatlas_advanced_cluster" "ar_not_electable" {
+  project_id   = var.project_id
+  name         = "ar"
+  cluster_type = "REPLICASET"
+  replication_specs = [
+    {
+      region_configs = [
+        {
+          provider_name = "AWS"
+          region_name   = "US_EAST_1"
+          priority      = 7
+          read_only_specs = {
+            node_count      = 1
+            instance_size   = "M10"
+            disk_size_gb    = 90
+            ebs_volume_type = "PROVISIONED"
+            disk_iops       = 100
+          }
+          analytics_specs = {
+            node_count      = 2
+            instance_size   = "M10"
+            disk_size_gb    = 90
+            ebs_volume_type = "PROVISIONED"
+            disk_iops       = 100
+          }
+        }
+      ]
+    }
+  ]
+
+  # Generated by atlas-cli-plugin-terraform.
+  # Please review the changes and confirm that references to this resource are updated.
+}

internal/convert/testdata/clu2adv/analytics_read_only_min_params.in.tf

@@ -15,3 +15,20 @@ resource "mongodbatlas_cluster" "ar" {
     }
   }
 }
+
+resource "mongodbatlas_cluster" "ar_not_electable" {
+  project_id                  = var.project_id
+  name                        = "ar"
+  cluster_type                = "REPLICASET"
+  provider_name               = "AWS"
+  provider_instance_size_name = "M10"
+  replication_specs {
+    num_shards = 1
+    regions_config {
+      region_name     = "US_EAST_1"
+      priority        = 7
+      analytics_nodes = 2
+      read_only_nodes = 1
+    }
+  }
+}

internal/convert/testdata/clu2adv/analytics_read_only_min_params.out.tf

@@ -29,3 +29,31 @@ resource "mongodbatlas_advanced_cluster" "ar" {
   # Generated by atlas-cli-plugin-terraform.
   # Please review the changes and confirm that references to this resource are updated.
 }
+
+resource "mongodbatlas_advanced_cluster" "ar_not_electable" {
+  project_id   = var.project_id
+  name         = "ar"
+  cluster_type = "REPLICASET"
+  replication_specs = [
+    {
+      region_configs = [
+        {
+          provider_name = "AWS"
+          region_name   = "US_EAST_1"
+          priority      = 7
+          read_only_specs = {
+            node_count    = 1
+            instance_size = "M10"
+          }
+          analytics_specs = {
+            node_count    = 2
+            instance_size = "M10"
+          }
+        }
+      ]
+    }
+  ]
+
+  # Generated by atlas-cli-plugin-terraform.
+  # Please review the changes and confirm that references to this resource are updated.
+}

internal/convert/testdata/clu2adv/errors.json

@@ -3,7 +3,6 @@
 	"free_cluster_missing_attribute": "free cluster (because no replication_specs): attribute backing_provider_name not found",
 	"autoscaling_missing_attribute": "setting replication_specs: attribute provider_instance_size_name not found",
 	"replication_specs_missing_regions_config": "setting replication_specs: regions_config not found",
-	"regions_config_missing_electable_nodes": "setting replication_specs: attribute electable_nodes not found",
 	"regions_config_missing_priority": "setting replication_specs: attribute priority not found",
 	"replication_specs_unsupported_dynamic": "dynamic blocks are not supported",
 	"replication_specs_non_literal_num_shards": "setting num_shards: failed to evaluate number",