update comment

lantoli · lantoli · commit 5dfbedefa147 · 2025-03-18T09:11:08.000+01:00
diff --git a/internal/convert/convert.go b/internal/convert/convert.go
@@ -31,7 +31,7 @@ const (
 	errNumShards   = "setting " + nNumShards
 
 	commentGeneratedBy       = "Generated by atlas-cli-plugin-terraform."
-	commentConfirmReferences = "Please confirm that all references to this resource are updated."
+	commentConfirmReferences = "Please review the changes and confirm that references to this resource are updated."
 	commentMovedBlock        = "Moved blocks"
 	commentRemovedOld        = "Note: Remember to remove or comment out the old cluster definitions."
 )
diff --git a/internal/convert/testdata/clu2adv/adv_config_bi_connector_pinned_fcv.out.tf b/internal/convert/testdata/clu2adv/adv_config_bi_connector_pinned_fcv.out.tf
@@ -32,5 +32,5 @@ resource "mongodbatlas_advanced_cluster" "this" {
   }
 
   # Generated by atlas-cli-plugin-terraform.
-  # Please confirm that all references to this resource are updated.
+  # Please review the changes and confirm that references to this resource are updated.
 }
diff --git a/internal/convert/testdata/clu2adv/analytics_read_only_all_params.out.tf b/internal/convert/testdata/clu2adv/analytics_read_only_all_params.out.tf
@@ -36,5 +36,5 @@ resource "mongodbatlas_advanced_cluster" "ar" {
   ]
 
   # Generated by atlas-cli-plugin-terraform.
-  # Please confirm that all references to this resource are updated.
+  # Please review the changes and confirm that references to this resource are updated.
 }
diff --git a/internal/convert/testdata/clu2adv/analytics_read_only_min_params.out.tf b/internal/convert/testdata/clu2adv/analytics_read_only_min_params.out.tf
@@ -27,5 +27,5 @@ resource "mongodbatlas_advanced_cluster" "ar" {
   ]
 
   # Generated by atlas-cli-plugin-terraform.
-  # Please confirm that all references to this resource are updated.
+  # Please review the changes and confirm that references to this resource are updated.
 }
diff --git a/internal/convert/testdata/clu2adv/autoscaling.out.tf b/internal/convert/testdata/clu2adv/autoscaling.out.tf
@@ -36,5 +36,5 @@ resource "mongodbatlas_advanced_cluster" "autoscaling" {
   ]
 
   # Generated by atlas-cli-plugin-terraform.
-  # Please confirm that all references to this resource are updated.
+  # Please review the changes and confirm that references to this resource are updated.
 }
diff --git a/internal/convert/testdata/clu2adv/data_sources.out.tf b/internal/convert/testdata/clu2adv/data_sources.out.tf
@@ -6,7 +6,7 @@ data "mongodbatlas_advanced_cluster" "singular" {
   use_replication_spec_per_shard = true
 
   # Generated by atlas-cli-plugin-terraform.
-  # Please confirm that all references to this resource are updated.
+  # Please review the changes and confirm that references to this resource are updated.
 }
 
 data "mongodbatlas_advanced_clusters" "plural" {
@@ -15,7 +15,7 @@ data "mongodbatlas_advanced_clusters" "plural" {
   use_replication_spec_per_shard = true
 
   # Generated by atlas-cli-plugin-terraform.
-  # Please confirm that all references to this resource are updated.
+  # Please review the changes and confirm that references to this resource are updated.
 }
 
 data "mongodbatlas_advanced_cluster" "adv_singular" {
diff --git a/internal/convert/testdata/clu2adv/dynamic_regions_config.out.tf b/internal/convert/testdata/clu2adv/dynamic_regions_config.out.tf
@@ -25,7 +25,7 @@ resource "mongodbatlas_advanced_cluster" "dynamic_regions_config" {
   ]
 
   # Generated by atlas-cli-plugin-terraform.
-  # Please confirm that all references to this resource are updated.
+  # Please review the changes and confirm that references to this resource are updated.
 }
 
 # example of variable for demostration purposes, not used in the conversion
diff --git a/internal/convert/testdata/clu2adv/dynamic_tags_labels.out.tf b/internal/convert/testdata/clu2adv/dynamic_tags_labels.out.tf
@@ -20,7 +20,7 @@ resource "mongodbatlas_advanced_cluster" "simplified" {
   tags = var.tags
 
   # Generated by atlas-cli-plugin-terraform.
-  # Please confirm that all references to this resource are updated.
+  # Please review the changes and confirm that references to this resource are updated.
 }
 
 resource "mongodbatlas_advanced_cluster" "expression" {
@@ -47,7 +47,7 @@ resource "mongodbatlas_advanced_cluster" "expression" {
   }
 
   # Generated by atlas-cli-plugin-terraform.
-  # Please confirm that all references to this resource are updated.
+  # Please review the changes and confirm that references to this resource are updated.
 }
 
 resource "mongodbatlas_advanced_cluster" "simplified_individual" {
@@ -78,7 +78,7 @@ resource "mongodbatlas_advanced_cluster" "simplified_individual" {
   )
 
   # Generated by atlas-cli-plugin-terraform.
-  # Please confirm that all references to this resource are updated.
+  # Please review the changes and confirm that references to this resource are updated.
 }
 
 resource "mongodbatlas_advanced_cluster" "expression_individual" {
@@ -111,7 +111,7 @@ resource "mongodbatlas_advanced_cluster" "expression_individual" {
   )
 
   # Generated by atlas-cli-plugin-terraform.
-  # Please confirm that all references to this resource are updated.
+  # Please review the changes and confirm that references to this resource are updated.
 }
 
 resource "mongodbatlas_advanced_cluster" "full_example" {
@@ -157,5 +157,5 @@ resource "mongodbatlas_advanced_cluster" "full_example" {
   )
 
   # Generated by atlas-cli-plugin-terraform.
-  # Please confirm that all references to this resource are updated.
+  # Please review the changes and confirm that references to this resource are updated.
 }
diff --git a/internal/convert/testdata/clu2adv/free_cluster_with_count.out.tf b/internal/convert/testdata/clu2adv/free_cluster_with_count.out.tf
@@ -26,5 +26,5 @@ resource "mongodbatlas_advanced_cluster" "free_cluster" { # comment in the resou
   ]
 
   # Generated by atlas-cli-plugin-terraform.
-  # Please confirm that all references to this resource are updated.
+  # Please review the changes and confirm that references to this resource are updated.
 }
diff --git a/internal/convert/testdata/clu2adv/includeMoved_multiple.out.tf b/internal/convert/testdata/clu2adv/includeMoved_multiple.out.tf
@@ -19,7 +19,7 @@ resource "mongodbatlas_advanced_cluster" "cluster1" {
   ]
 
   # Generated by atlas-cli-plugin-terraform.
-  # Please confirm that all references to this resource are updated.
+  # Please review the changes and confirm that references to this resource are updated.
 }
 
 resource "mongodbatlas_advanced_cluster" "cluster2" {
@@ -43,7 +43,7 @@ resource "mongodbatlas_advanced_cluster" "cluster2" {
   ]
 
   # Generated by atlas-cli-plugin-terraform.
-  # Please confirm that all references to this resource are updated.
+  # Please review the changes and confirm that references to this resource are updated.
 }
 
 resource "mongodbatlas_advanced_cluster" "count" {
@@ -69,7 +69,7 @@ resource "mongodbatlas_advanced_cluster" "count" {
   ]
 
   # Generated by atlas-cli-plugin-terraform.
-  # Please confirm that all references to this resource are updated.
+  # Please review the changes and confirm that references to this resource are updated.
 }
 
 resource "mongodbatlas_advanced_cluster" "forEach" {
@@ -95,7 +95,7 @@ resource "mongodbatlas_advanced_cluster" "forEach" {
   ]
 
   # Generated by atlas-cli-plugin-terraform.
-  # Please confirm that all references to this resource are updated.
+  # Please review the changes and confirm that references to this resource are updated.
 }
 
 resource "another_resource" "another" {
diff --git a/internal/convert/testdata/clu2adv/includeMoved_single.out.tf b/internal/convert/testdata/clu2adv/includeMoved_single.out.tf
@@ -19,7 +19,7 @@ resource "mongodbatlas_advanced_cluster" "cluster" {
   ]
 
   # Generated by atlas-cli-plugin-terraform.
-  # Please confirm that all references to this resource are updated.
+  # Please review the changes and confirm that references to this resource are updated.
 }
 
 # Moved blocks
diff --git a/internal/convert/testdata/clu2adv/multi_region.out.tf b/internal/convert/testdata/clu2adv/multi_region.out.tf
@@ -43,5 +43,5 @@ resource "mongodbatlas_advanced_cluster" "multi_region" {
   ]
 
   # Generated by atlas-cli-plugin-terraform.
-  # Please confirm that all references to this resource are updated.
+  # Please review the changes and confirm that references to this resource are updated.
 }
diff --git a/internal/convert/testdata/clu2adv/multi_replicaction_specs.out.tf b/internal/convert/testdata/clu2adv/multi_replicaction_specs.out.tf
@@ -37,7 +37,7 @@ resource "mongodbatlas_advanced_cluster" "multirep" {
   ]
 
   # Generated by atlas-cli-plugin-terraform.
-  # Please confirm that all references to this resource are updated.
+  # Please review the changes and confirm that references to this resource are updated.
 }
 
 resource "mongodbatlas_advanced_cluster" "geo" {
@@ -124,5 +124,5 @@ resource "mongodbatlas_advanced_cluster" "geo" {
   ]
 
   # Generated by atlas-cli-plugin-terraform.
-  # Please confirm that all references to this resource are updated.
+  # Please review the changes and confirm that references to this resource are updated.
 }
diff --git a/internal/convert/testdata/clu2adv/tags_labels_timeouts.out.tf b/internal/convert/testdata/clu2adv/tags_labels_timeouts.out.tf
@@ -22,7 +22,7 @@ resource "mongodbatlas_advanced_cluster" "basictags" {
   }
 
   # Generated by atlas-cli-plugin-terraform.
-  # Please confirm that all references to this resource are updated.
+  # Please review the changes and confirm that references to this resource are updated.
 }
 
 resource "mongodbatlas_advanced_cluster" "basictimeouts" {
@@ -49,7 +49,7 @@ resource "mongodbatlas_advanced_cluster" "basictimeouts" {
   }
 
   # Generated by atlas-cli-plugin-terraform.
-  # Please confirm that all references to this resource are updated.
+  # Please review the changes and confirm that references to this resource are updated.
 }
 
 resource "mongodbatlas_advanced_cluster" "all" {
@@ -88,5 +88,5 @@ resource "mongodbatlas_advanced_cluster" "all" {
   }
 
   # Generated by atlas-cli-plugin-terraform.
-  # Please confirm that all references to this resource are updated.
+  # Please review the changes and confirm that references to this resource are updated.
 }
diff --git a/test/e2e/testdata/clu2adv.expected.tf b/test/e2e/testdata/clu2adv.expected.tf
@@ -22,5 +22,5 @@ resource "mongodbatlas_advanced_cluster" "cluster" {
   }
 
   # Generated by atlas-cli-plugin-terraform.
-  # Please confirm that all references to this resource are updated.
+  # Please review the changes and confirm that references to this resource are updated.
 }
diff --git a/test/e2e/testdata/clu2adv.expected_moved.tf b/test/e2e/testdata/clu2adv.expected_moved.tf
@@ -22,7 +22,7 @@ resource "mongodbatlas_advanced_cluster" "cluster" {
   }
 
   # Generated by atlas-cli-plugin-terraform.
-  # Please confirm that all references to this resource are updated.
+  # Please review the changes and confirm that references to this resource are updated.
 }
 
 # Moved blocks

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ const (`
`31`	`31`	`errNumShards = "setting " + nNumShards`
`32`	`32`
`33`	`33`	`commentGeneratedBy = "Generated by atlas-cli-plugin-terraform."`
`34`		`- commentConfirmReferences = "Please confirm that all references to this resource are updated."`
	`34`	`+ commentConfirmReferences = "Please review the changes and confirm that references to this resource are updated."`
`35`	`35`	`commentMovedBlock = "Moved blocks"`
`36`	`36`	`commentRemovedOld = "Note: Remember to remove or comment out the old cluster definitions."`
`37`	`37`	`)`
Original file line number	Diff line number	Diff line change
`@@ -32,5 +32,5 @@ resource "mongodbatlas_advanced_cluster" "this" {`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`# Generated by atlas-cli-plugin-terraform.`
`35`		`- # Please confirm that all references to this resource are updated.`
	`35`	`+ # Please review the changes and confirm that references to this resource are updated.`
`36`	`36`	`}`
Original file line number	Diff line number	Diff line change
`@@ -36,5 +36,5 @@ resource "mongodbatlas_advanced_cluster" "ar" {`
`36`	`36`	`]`
`37`	`37`
`38`	`38`	`# Generated by atlas-cli-plugin-terraform.`
`39`		`- # Please confirm that all references to this resource are updated.`
	`39`	`+ # Please review the changes and confirm that references to this resource are updated.`
`40`	`40`	`}`
Original file line number	Diff line number	Diff line change
`@@ -27,5 +27,5 @@ resource "mongodbatlas_advanced_cluster" "ar" {`
`27`	`27`	`]`
`28`	`28`
`29`	`29`	`# Generated by atlas-cli-plugin-terraform.`
`30`		`- # Please confirm that all references to this resource are updated.`
	`30`	`+ # Please review the changes and confirm that references to this resource are updated.`
`31`	`31`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ data "mongodbatlas_advanced_cluster" "singular" {`
`6`	`6`	`use_replication_spec_per_shard = true`
`7`	`7`
`8`	`8`	`# Generated by atlas-cli-plugin-terraform.`
`9`		`- # Please confirm that all references to this resource are updated.`
	`9`	`+ # Please review the changes and confirm that references to this resource are updated.`
`10`	`10`	`}`
`11`	`11`
`12`	`12`	`data "mongodbatlas_advanced_clusters" "plural" {`
`@@ -15,7 +15,7 @@ data "mongodbatlas_advanced_clusters" "plural" {`
`15`	`15`	`use_replication_spec_per_shard = true`
`16`	`16`
`17`	`17`	`# Generated by atlas-cli-plugin-terraform.`
`18`		`- # Please confirm that all references to this resource are updated.`
	`18`	`+ # Please review the changes and confirm that references to this resource are updated.`
`19`	`19`	`}`
`20`	`20`
`21`	`21`	`data "mongodbatlas_advanced_cluster" "adv_singular" {`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ resource "mongodbatlas_advanced_cluster" "dynamic_regions_config" {`
`25`	`25`	`]`
`26`	`26`
`27`	`27`	`# Generated by atlas-cli-plugin-terraform.`
`28`		`- # Please confirm that all references to this resource are updated.`
	`28`	`+ # Please review the changes and confirm that references to this resource are updated.`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`# example of variable for demostration purposes, not used in the conversion`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ resource "mongodbatlas_advanced_cluster" "simplified" {`
`20`	`20`	`tags = var.tags`
`21`	`21`
`22`	`22`	`# Generated by atlas-cli-plugin-terraform.`
`23`		`- # Please confirm that all references to this resource are updated.`
	`23`	`+ # Please review the changes and confirm that references to this resource are updated.`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`resource "mongodbatlas_advanced_cluster" "expression" {`
`@@ -47,7 +47,7 @@ resource "mongodbatlas_advanced_cluster" "expression" {`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`# Generated by atlas-cli-plugin-terraform.`
`50`		`- # Please confirm that all references to this resource are updated.`
	`50`	`+ # Please review the changes and confirm that references to this resource are updated.`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`resource "mongodbatlas_advanced_cluster" "simplified_individual" {`
`@@ -78,7 +78,7 @@ resource "mongodbatlas_advanced_cluster" "simplified_individual" {`
`78`	`78`	`)`
`79`	`79`
`80`	`80`	`# Generated by atlas-cli-plugin-terraform.`
`81`		`- # Please confirm that all references to this resource are updated.`
	`81`	`+ # Please review the changes and confirm that references to this resource are updated.`
`82`	`82`	`}`
`83`	`83`
`84`	`84`	`resource "mongodbatlas_advanced_cluster" "expression_individual" {`
`@@ -111,7 +111,7 @@ resource "mongodbatlas_advanced_cluster" "expression_individual" {`
`111`	`111`	`)`
`112`	`112`
`113`	`113`	`# Generated by atlas-cli-plugin-terraform.`
`114`		`- # Please confirm that all references to this resource are updated.`
	`114`	`+ # Please review the changes and confirm that references to this resource are updated.`
`115`	`115`	`}`
`116`	`116`
`117`	`117`	`resource "mongodbatlas_advanced_cluster" "full_example" {`
`@@ -157,5 +157,5 @@ resource "mongodbatlas_advanced_cluster" "full_example" {`
`157`	`157`	`)`
`158`	`158`
`159`	`159`	`# Generated by atlas-cli-plugin-terraform.`
`160`		`- # Please confirm that all references to this resource are updated.`
	`160`	`+ # Please review the changes and confirm that references to this resource are updated.`
`161`	`161`	`}`
Original file line number	Diff line number	Diff line change
`@@ -26,5 +26,5 @@ resource "mongodbatlas_advanced_cluster" "free_cluster" { # comment in the resou`
`26`	`26`	`]`
`27`	`27`
`28`	`28`	`# Generated by atlas-cli-plugin-terraform.`
`29`		`- # Please confirm that all references to this resource are updated.`
	`29`	`+ # Please review the changes and confirm that references to this resource are updated.`
`30`	`30`	`}`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ resource "mongodbatlas_advanced_cluster" "cluster1" {`
`19`	`19`	`]`
`20`	`20`
`21`	`21`	`# Generated by atlas-cli-plugin-terraform.`
`22`		`- # Please confirm that all references to this resource are updated.`
	`22`	`+ # Please review the changes and confirm that references to this resource are updated.`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`resource "mongodbatlas_advanced_cluster" "cluster2" {`
`@@ -43,7 +43,7 @@ resource "mongodbatlas_advanced_cluster" "cluster2" {`
`43`	`43`	`]`
`44`	`44`
`45`	`45`	`# Generated by atlas-cli-plugin-terraform.`
`46`		`- # Please confirm that all references to this resource are updated.`
	`46`	`+ # Please review the changes and confirm that references to this resource are updated.`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`resource "mongodbatlas_advanced_cluster" "count" {`
`@@ -69,7 +69,7 @@ resource "mongodbatlas_advanced_cluster" "count" {`
`69`	`69`	`]`
`70`	`70`
`71`	`71`	`# Generated by atlas-cli-plugin-terraform.`
`72`		`- # Please confirm that all references to this resource are updated.`
	`72`	`+ # Please review the changes and confirm that references to this resource are updated.`
`73`	`73`	`}`
`74`	`74`
`75`	`75`	`resource "mongodbatlas_advanced_cluster" "forEach" {`
`@@ -95,7 +95,7 @@ resource "mongodbatlas_advanced_cluster" "forEach" {`
`95`	`95`	`]`
`96`	`96`
`97`	`97`	`# Generated by atlas-cli-plugin-terraform.`
`98`		`- # Please confirm that all references to this resource are updated.`
	`98`	`+ # Please review the changes and confirm that references to this resource are updated.`
`99`	`99`	`}`
`100`	`100`
`101`	`101`	`resource "another_resource" "another" {`