no need to pass param nAdvConf as this func is only used for advanced_configuration

Author: lantoli

internal/convert/adv2v2.go

@@ -50,7 +50,7 @@ func updateResource(resource *hclwrite.Block) (bool, error) {
 	if err := fillTagsLabelsOpt(resourceb, nLabels); err != nil {
 		return false, err
 	}
-	fillAdvConfigOpt(resourceb, nAdvConf)
+	fillAdvConfigOpt(resourceb)
 	fillBlockOpt(resourceb, nBiConnector)
 	fillBlockOpt(resourceb, nPinnedFCV)
 	fillBlockOpt(resourceb, nTimeouts)

internal/convert/clu2adv.go

@@ -164,7 +164,7 @@ func fillCluster(resourceb *hclwrite.Body) error {
 	if err := fillTagsLabelsOpt(resourceb, nLabels); err != nil {
 		return err
 	}
-	fillAdvConfigOpt(resourceb, nAdvConf)
+	fillAdvConfigOpt(resourceb)
 	fillBlockOpt(resourceb, nBiConnector)
 	fillBlockOpt(resourceb, nPinnedFCV)
 	fillBlockOpt(resourceb, nTimeouts)
@@ -303,8 +303,8 @@ func fillBlockOpt(resourceb *hclwrite.Body, name string) {
 	resourceb.SetAttributeRaw(name, hcl.TokensObject(block.Body()))
 }
 
-func fillAdvConfigOpt(resourceb *hclwrite.Body, name string) {
-	block := resourceb.FirstMatchingBlock(name, nil)
+func fillAdvConfigOpt(resourceb *hclwrite.Body) {
+	block := resourceb.FirstMatchingBlock(nAdvConf, nil)
 	if block == nil {
 		return
 	}
@@ -314,7 +314,7 @@ func fillAdvConfigOpt(resourceb *hclwrite.Body, name string) {
 	blockBody.RemoveAttribute(nFailIndexKeyTooLong)
 	blockBody.RemoveAttribute(nDefaultReadConcern)
 
-	fillBlockOpt(resourceb, name)
+	fillBlockOpt(resourceb, nAdvConf)
 }
 
 // fillReplicationSpecsWithDynamicBlock used for dynamic blocks in replication_specs