fix quotes

lantoli · lantoli · commit afbfe4fcd304 · 2025-02-13T18:45:58.000+01:00
diff --git a/internal/convert/testdata/clu2adv/tags_labels_timeouts.out.tf b/internal/convert/testdata/clu2adv/tags_labels_timeouts.out.tf
@@ -62,11 +62,11 @@ resource "mongodbatlas_advanced_cluster" "all" {
   }]
   tags = {
     environment = "dev"
-    Tag 2       = "Value 2"
+    "Tag 2"     = "Value 2"
   }
   labels = {
-    label1  = "Val label 1"
-    Label 2 = "label val 2"
+    label1    = "Val label 1"
+    "Label 2" = "label val 2"
   }
   timeouts = {
 
diff --git a/internal/hcl/hcl.go b/internal/hcl/hcl.go
@@ -68,7 +68,11 @@ func GetAttrString(attr *hclwrite.Attribute, errPrefix string) (string, error) {
 	if !val.Type().Equals(cty.String) {
 		return "", fmt.Errorf("%s: attribute is not a string", errPrefix)
 	}
-	return val.AsString(), nil
+	str := val.AsString()
+	if !hclsyntax.ValidIdentifier(str) {
+		str = strconv.Quote(str)
+	}
+	return str, nil
 }
 
 // TokensArray creates an array of objects.

Original file line number	Diff line number	Diff line change
`@@ -62,11 +62,11 @@ resource "mongodbatlas_advanced_cluster" "all" {`
`62`	`62`	`}]`
`63`	`63`	`tags = {`
`64`	`64`	`environment = "dev"`
`65`		`- Tag 2 = "Value 2"`
	`65`	`+ "Tag 2" = "Value 2"`
`66`	`66`	`}`
`67`	`67`	`labels = {`
`68`		`- label1 = "Val label 1"`
`69`		`- Label 2 = "label val 2"`
	`68`	`+ label1 = "Val label 1"`
	`69`	`+ "Label 2" = "label val 2"`
`70`	`70`	`}`
`71`	`71`	`timeouts = {`
`72`	`72`
Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,11 @@ func GetAttrString(attr *hclwrite.Attribute, errPrefix string) (string, error) {`
`68`	`68`	`if !val.Type().Equals(cty.String) {`
`69`	`69`	`return "", fmt.Errorf("%s: attribute is not a string", errPrefix)`
`70`	`70`	`}`
`71`		`- return val.AsString(), nil`
	`71`	`+ str := val.AsString()`
	`72`	`+ if !hclsyntax.ValidIdentifier(str) {`
	`73`	`+ str = strconv.Quote(str)`
	`74`	`+ }`
	`75`	`+ return str, nil`
`72`	`76`	`}`
`73`	`77`
`74`	`78`	`// TokensArray creates an array of objects.`