small refactor

lantoli · lantoli · commit bef160db45ae · 2025-02-06T10:57:22.000+01:00
diff --git a/internal/hcl/hcl.go b/internal/hcl/hcl.go
@@ -86,14 +86,14 @@ func fillReplicationSpecs(body *hclwrite.Body) error {
 	}
 
 	body.RemoveAttribute(nNumShards) // num_shards in root is not relevant, only in replication_specs
-	// ok moveAttr to fail as cloud_backup is optional
+	// ok to fail as cloud_backup is optional
 	_ = moveAttr(body, body, nCloudBackup, nBackupEnabled, errRepSpecs)
 
-	repSpecs := hclwrite.NewEmptyFile()
 	config, errConfig := getRegionConfigs(configSrc, root)
 	if errConfig != nil {
 		return errConfig
 	}
+	repSpecs := hclwrite.NewEmptyFile()
 	repSpecs.Body().SetAttributeRaw(nConfig, config)
 	body.SetAttributeRaw(nRepSpecs, tokensArrayObject(repSpecs))
 

Original file line number	Diff line number	Diff line change
`@@ -86,14 +86,14 @@ func fillReplicationSpecs(body *hclwrite.Body) error {`
`86`	`86`	`}`
`87`	`87`
`88`	`88`	`body.RemoveAttribute(nNumShards) // num_shards in root is not relevant, only in replication_specs`
`89`		`- // ok moveAttr to fail as cloud_backup is optional`
	`89`	`+ // ok to fail as cloud_backup is optional`
`90`	`90`	`_ = moveAttr(body, body, nCloudBackup, nBackupEnabled, errRepSpecs)`
`91`	`91`
`92`		`- repSpecs := hclwrite.NewEmptyFile()`
`93`	`92`	`config, errConfig := getRegionConfigs(configSrc, root)`
`94`	`93`	`if errConfig != nil {`
`95`	`94`	`return errConfig`
`96`	`95`	`}`
	`96`	`+ repSpecs := hclwrite.NewEmptyFile()`
`97`	`97`	`repSpecs.Body().SetAttributeRaw(nConfig, config)`
`98`	`98`	`body.SetAttributeRaw(nRepSpecs, tokensArrayObject(repSpecs))`
`99`	`99`