allow dynamic block in regions_config

lantoli · lantoli · commit cf5e3f7803b3 · 2025-03-18T08:49:01.000+01:00
diff --git a/internal/convert/convert.go b/internal/convert/convert.go
@@ -37,7 +37,7 @@ const (
 )
 
 var (
-	dynamicBlockAllowList = []string{nTags, nLabels}
+	dynamicBlockAllowList = []string{nTags, nLabels, nConfigSrc}
 )
 
 type attrVals struct {
diff --git a/internal/convert/testdata/clu2adv/errors.json b/internal/convert/testdata/clu2adv/errors.json
@@ -8,7 +8,6 @@
 	"regions_config_out_of_range_priority": "setting priority: priority is 0 but must be between 1 and 7",
 	"regions_config_non_literal_priority": "setting priority: failed to evaluate number",
 	"replication_specs_unsupported_dynamic": "dynamic blocks are not supported",
-	"regions_config_unsupported_dynamic": "dynamic blocks are not supported",
 	"replication_specs_non_literal_num_shards": "setting num_shards: failed to evaluate number",
 	"replication_specs_missing_num_shards": "num_shards not found"
 }
diff --git a/internal/convert/testdata/clu2adv/regions_config_unsupported_dynamic.in.tf b/internal/convert/testdata/clu2adv/regions_config_unsupported_dynamic.in.tf

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ const (`
`37`	`37`	`)`
`38`	`38`
`39`	`39`	`var (`
`40`		`- dynamicBlockAllowList = []string{nTags, nLabels}`
	`40`	`+ dynamicBlockAllowList = []string{nTags, nLabels, nConfigSrc}`
`41`	`41`	`)`
`42`	`42`
`43`	`43`	`type attrVals struct {`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,6 @@`
`8`	`8`	`"regions_config_out_of_range_priority": "setting priority: priority is 0 but must be between 1 and 7",`
`9`	`9`	`"regions_config_non_literal_priority": "setting priority: failed to evaluate number",`
`10`	`10`	`"replication_specs_unsupported_dynamic": "dynamic blocks are not supported",`
`11`		`- "regions_config_unsupported_dynamic": "dynamic blocks are not supported",`
`12`	`11`	`"replication_specs_non_literal_num_shards": "setting num_shards: failed to evaluate number",`
`13`	`12`	`"replication_specs_missing_num_shards": "num_shards not found"`
`14`	`13`	`}`