num_shards

Author: lantoli

internal/convert/convert.go

@@ -142,17 +142,28 @@ func fillReplicationSpecs(resourceb *hclwrite.Body, root attrVals) error {
 		if specSrc == nil {
 			break
 		}
-		if err := checkDynamicBlock(specSrc.Body()); err != nil {
+		specbSrc := specSrc.Body()
+		if err := checkDynamicBlock(specbSrc); err != nil {
 			return err
 		}
 		configs, err := getRegionConfigs(specSrc, root)
 		if err != nil {
 			return err
 		}
 		// ok to fail as zone_name is optional
-		_ = hcl.MoveAttr(specSrc.Body(), specb, nZoneName, nZoneName, errRepSpecs)
+		_ = hcl.MoveAttr(specbSrc, specb, nZoneName, nZoneName, errRepSpecs)
 		specb.SetAttributeRaw(nConfig, configs)
-		specbs = append(specbs, specb)
+		shards := specbSrc.GetAttribute(nNumShards)
+		if shards == nil {
+			return fmt.Errorf("%s: %s not found", errRepSpecs, nNumShards)
+		}
+		shardsVal, err := hcl.GetAttrInt(shards, errRepSpecs)
+		if err != nil {
+			return err
+		}
+		for range shardsVal {
+			specbs = append(specbs, specb)
+		}
 		resourceb.RemoveBlock(specSrc)
 	}
 	resourceb.SetAttributeRaw(nRepSpecs, hcl.TokensArray(specbs))

internal/convert/testdata/clu2adv/multi_replicaction_specs.in.tf

@@ -26,3 +26,34 @@ resource "mongodbatlas_cluster" "multirep" {
     }
   }
 }
+
+resource "mongodbatlas_cluster" "geo" {
+  project_id                  = "1234"
+  name                        = "geo"
+  disk_size_gb                = 80
+  num_shards                  = 1
+  cloud_backup                = false
+  cluster_type                = "GEOSHARDED"
+  provider_name               = "AWS"
+  provider_instance_size_name = "M10"
+  replication_specs {
+    zone_name  = "Zone 1"
+    num_shards = 2
+    regions_config {
+      region_name     = "US_EAST_1"
+      electable_nodes = 3
+      priority        = 7
+      read_only_nodes = 0
+    }
+  }
+  replication_specs {
+    zone_name  = "Zone 2"
+    num_shards = 3
+    regions_config {
+      region_name     = "US_WEST_2"
+      electable_nodes = 3
+      priority        = 7
+      read_only_nodes = 0
+    }
+  }
+}

internal/convert/testdata/clu2adv/multi_replicaction_specs.out.tf

@@ -39,3 +39,90 @@ resource "mongodbatlas_advanced_cluster" "multirep" {
   # Generated by atlas-cli-plugin-terraform.
   # Please confirm that all references to this resource are updated.
 }
+
+resource "mongodbatlas_advanced_cluster" "geo" {
+  project_id     = "1234"
+  name           = "geo"
+  cluster_type   = "GEOSHARDED"
+  backup_enabled = false
+  replication_specs = [
+    {
+      zone_name = "Zone 1"
+      region_configs = [
+        {
+          provider_name = "AWS"
+          region_name   = "US_EAST_1"
+          priority      = 7
+          electable_specs = {
+            node_count    = 3
+            instance_size = "M10"
+            disk_size_gb  = 80
+          }
+        }
+      ]
+    },
+    {
+      zone_name = "Zone 1"
+      region_configs = [
+        {
+          provider_name = "AWS"
+          region_name   = "US_EAST_1"
+          priority      = 7
+          electable_specs = {
+            node_count    = 3
+            instance_size = "M10"
+            disk_size_gb  = 80
+          }
+        }
+      ]
+    },
+    {
+      zone_name = "Zone 2"
+      region_configs = [
+        {
+          provider_name = "AWS"
+          region_name   = "US_WEST_2"
+          priority      = 7
+          electable_specs = {
+            node_count    = 3
+            instance_size = "M10"
+            disk_size_gb  = 80
+          }
+        }
+      ]
+    },
+    {
+      zone_name = "Zone 2"
+      region_configs = [
+        {
+          provider_name = "AWS"
+          region_name   = "US_WEST_2"
+          priority      = 7
+          electable_specs = {
+            node_count    = 3
+            instance_size = "M10"
+            disk_size_gb  = 80
+          }
+        }
+      ]
+    },
+    {
+      zone_name = "Zone 2"
+      region_configs = [
+        {
+          provider_name = "AWS"
+          region_name   = "US_WEST_2"
+          priority      = 7
+          electable_specs = {
+            node_count    = 3
+            instance_size = "M10"
+            disk_size_gb  = 80
+          }
+        }
+      ]
+    }
+  ]
+
+  # Generated by atlas-cli-plugin-terraform.
+  # Please confirm that all references to this resource are updated.
+}