extract consts

Author: lantoli

internal/hcl/hcl.go

@@ -8,6 +8,12 @@ import (
 	"github.com/hashicorp/hcl/v2/hclwrite"
 )
 
+const (
+	resourceType = "resource"
+	cluster      = "mongodbatlas_cluster"
+	advCluster   = "mongodbatlas_advanced_cluster"
+)
+
 // ClusterToAdvancedCluster transforms all cluster definition in a
 // Terraform config file into an advanced_cluster definition.
 // All other resources and data sources are left untouched.
@@ -18,16 +24,15 @@ func ClusterToAdvancedCluster(config []byte) ([]byte, error) {
 		return nil, err
 	}
 	for _, resource := range parser.Body().Blocks() {
-		isResource := resource.Type() == "resource"
 		labels := resource.Labels()
 		resourceName := labels[0]
-		if !isResource || resourceName != "mongodbatlas_cluster" {
+		if resource.Type() != resourceType || resourceName != cluster {
 			continue
 		}
 		resourceBody := resource.Body()
 
 		// TODO: Do the full transformation
-		labels[0] = "mongodbatlas_advanced_cluster"
+		labels[0] = advCluster
 		resource.SetLabels(labels)
 		resourceBody.AppendNewline()
 		appendComment(resourceBody, "Generated by atlas-cli-plugin-terraform.")