moveAttribute & extractAttr

Author: lantoli

internal/hcl/hcl.go

@@ -26,11 +26,16 @@ const (
 	nameInstanceSize             = "instance_size"
 	nameClusterType              = "cluster_type"
 	namePriority                 = "priority"
+	nameNumShards                = "num_shards"
+	nameBackupEnabled            = "backup_enabled"
+	nameCloudBackup              = "cloud_backup"
+	nameDiskSizeGB               = "disk_size_gb"
 
 	valClusterType = "REPLICASET"
 	valPriority    = 7
 
 	errFreeCluster = "free cluster (because no " + nameReplicationSpecs + ")"
+	errRepSpecs    = "setting " + nameReplicationSpecs
 )
 
 // ClusterToAdvancedCluster transforms all mongodbatlas_cluster definitions in a
@@ -74,17 +79,17 @@ func fillFreeTier(body *hclwrite.Body) error {
 	regionConfig := hclwrite.NewEmptyFile()
 	regionConfigBody := regionConfig.Body()
 	setAttrInt(regionConfigBody, "priority", valPriority)
-	if err := moveAttribute(nameProviderRegionName, nameRegionName, body, regionConfigBody, errFreeCluster); err != nil {
+	if err := moveAttr(body, regionConfigBody, nameProviderRegionName, nameRegionName, errFreeCluster); err != nil {
 		return err
 	}
-	if err := moveAttribute(nameProviderName, nameProviderName, body, regionConfigBody, errFreeCluster); err != nil {
+	if err := moveAttr(body, regionConfigBody, nameProviderName, nameProviderName, errFreeCluster); err != nil {
 		return err
 	}
-	if err := moveAttribute(nameBackingProviderName, nameBackingProviderName, body, regionConfigBody, errFreeCluster); err != nil {
+	if err := moveAttr(body, regionConfigBody, nameBackingProviderName, nameBackingProviderName, errFreeCluster); err != nil {
 		return err
 	}
 	electableSpec := hclwrite.NewEmptyFile()
-	if err := moveAttribute(nameProviderInstanceSizeName, nameInstanceSize, body, electableSpec.Body(), errFreeCluster); err != nil {
+	if err := moveAttr(body, electableSpec.Body(), nameProviderInstanceSizeName, nameInstanceSize, errFreeCluster); err != nil {
 		return err
 	}
 	regionConfigBody.SetAttributeRaw(nameElectableSpecs, tokensObject(electableSpec))
@@ -96,17 +101,54 @@ func fillFreeTier(body *hclwrite.Body) error {
 }
 
 func fillReplicationSpecs(body *hclwrite.Body) error {
+	diskSizeGBOptional, _ := extractAttr(body, nameDiskSizeGB, errRepSpecs)
+	providerName, err := extractAttr(body, nameProviderName, errRepSpecs)
+	if err != nil {
+		return nil
+	}
+
+	srcReplicationSpecs := body.FirstMatchingBlock(nameReplicationSpecs, nil)
+	// srcRegionsConfig := srcReplicationSpecs.Body().FirstMatchingBlock(nameRegionConfigs, nil)
+	// regionName := srcRegionsConfig.Body().GetAttribute(nameRegionName)
+
+	body.RemoveAttribute(nameNumShards) // num_shards in root is not relevant, only in replication_specs
+	// ok moveAttr to fail as cloud_backup is optional
+	_ = moveAttr(body, body, nameCloudBackup, nameBackupEnabled, errRepSpecs)
+
+	electableSpec := hclwrite.NewEmptyFile()
+
+	regionConfig := hclwrite.NewEmptyFile()
+	regionConfigBody := regionConfig.Body()
+	regionConfigBody.SetAttributeRaw(nameElectableSpecs, tokensObject(electableSpec))
+
+	replicationSpec := hclwrite.NewEmptyFile()
+	replicationSpec.Body().SetAttributeRaw(nameRegionConfigs, tokensArrayObject(regionConfig))
+	body.SetAttributeRaw(nameReplicationSpecs, tokensArrayObject(replicationSpec))
+
+	_, _ = diskSizeGBOptional, providerName
+
+	body.RemoveBlock(srcReplicationSpecs)
 	return nil
 }
 
-func moveAttribute(fromAttrName, toAttrName string, fromBody, toBody *hclwrite.Body, errPrefix string) error {
-	attr := fromBody.GetAttribute(fromAttrName)
+// moveAttr deletes an attribute from fromBody and adds it to toBody.
+func moveAttr(fromBody, toBody *hclwrite.Body, fromAttrName, toAttrName, errPrefix string) error {
+	tokens, err := extractAttr(fromBody, fromAttrName, errPrefix)
+	if err == nil {
+		toBody.SetAttributeRaw(toAttrName, tokens)
+	}
+	return err
+}
+
+// extractAttr deletes an attribute and returns it value.
+func extractAttr(body *hclwrite.Body, attrName, errPrefix string) (hclwrite.Tokens, error) {
+	attr := body.GetAttribute(attrName)
 	if attr == nil {
-		return fmt.Errorf("%s: attribute %s not found", errPrefix, fromAttrName)
+		return nil, fmt.Errorf("%s: attribute %s not found", errPrefix, attrName)
 	}
-	fromBody.RemoveAttribute(fromAttrName)
-	toBody.SetAttributeRaw(toAttrName, attr.Expr().BuildTokens(nil))
-	return nil
+	tokens := attr.Expr().BuildTokens(nil)
+	body.RemoveAttribute(attrName)
+	return tokens, nil
 }
 
 func setAttrInt(body *hclwrite.Body, attrName string, number int) {

internal/hcl/testdata/clu2adv/autoscaling.in.tf

@@ -3,8 +3,8 @@ resource "mongodbatlas_cluster" "autoscaling" {
   name         = var.cluster_name
   disk_size_gb = 100
   num_shards = 1
-
   cluster_type = "REPLICASET"
+  
   replication_specs {
     num_shards = 1
     regions_config {

internal/hcl/testdata/clu2adv/autoscaling.out.tf

@@ -1,20 +1,20 @@
 resource "mongodbatlas_advanced_cluster" "autoscaling" {
   project_id   = var.project_id
   name         = var.cluster_name
-  cluster_type   = "REPLICASET"
-  backup_enabled = true
- 
+  cluster_type = "REPLICASET"
+  
   lifecycle { // To simulate if there a new instance size name to avoid scale cluster down to original value
     # Note that provider_instance_size_name won't exist in advanced_cluster so it's an error to refer to it,
     # but plugin doesn't help here.
     ignore_changes = [provider_instance_size_name]
   }
-
+  backup_enabled = true
+ 
   replication_specs = [{
     region_configs = [{
+      provider_name = "AWS"
       region_name   = "US_WEST_2"
       priority      = 7
-      provider_name = "AWS"
       auto_scaling = {
         disk_gb_enabled            = true
         compute_enabled            = true
@@ -29,7 +29,7 @@ resource "mongodbatlas_advanced_cluster" "autoscaling" {
       }
     }]
   }]
-
+  
   # Generated by atlas-cli-plugin-terraform.
   # Please confirm that all references to this resource are updated.
 }