simplify unit tests

Author: lantoli

internal/convert/adv2new_test.go

@@ -1,51 +1,13 @@
 package convert_test
 
 import (
-	"encoding/json"
-	"path/filepath"
-	"strings"
 	"testing"
 
 	"github.com/mongodb-labs/atlas-cli-plugin-terraform/internal/convert"
-	"github.com/sebdah/goldie/v2"
-	"github.com/spf13/afero"
-	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/require"
 )
 
 func TestAdvancedClusterToNew(t *testing.T) {
-	const (
-		root        = "testdata/adv2new"
-		inSuffix    = ".in.tf"
-		outSuffix   = ".out.tf"
-		errFilename = "errors.json"
-	)
-	fs := afero.NewOsFs()
-	errMap := make(map[string]string)
-	errContent, err := afero.ReadFile(fs, filepath.Join(root, errFilename))
-	require.NoError(t, err)
-	err = json.Unmarshal(errContent, &errMap)
-	require.NoError(t, err)
-	g := goldie.New(t,
-		goldie.WithFixtureDir(root),
-		goldie.WithNameSuffix(outSuffix))
-	pattern := filepath.Join(root, "*"+inSuffix)
-	inputFiles, err := afero.Glob(fs, pattern)
-	require.NoError(t, err)
-	assert.NotEmpty(t, inputFiles)
-	for _, inputFile := range inputFiles {
-		testName := strings.TrimSuffix(filepath.Base(inputFile), inSuffix)
-		t.Run(testName, func(t *testing.T) {
-			inConfig, err := afero.ReadFile(fs, inputFile)
-			require.NoError(t, err)
-			outConfig, err := convert.AdvancedClusterToNew(inConfig)
-			if err == nil {
-				g.Assert(t, testName, outConfig)
-			} else {
-				errMsg, found := errMap[testName]
-				assert.True(t, found, "error not found in file %s for test %s, errMsg: %v", errFilename, testName, err)
-				assert.Contains(t, err.Error(), errMsg)
-			}
-		})
-	}
+	runConvertTests(t, "adv2new", func(testName string, inConfig []byte) ([]byte, error) {
+		return convert.AdvancedClusterToNew(inConfig)
+	})
 }

internal/convert/clu2adv_test.go

@@ -1,52 +1,15 @@
 package convert_test
 
 import (
-	"encoding/json"
-	"path/filepath"
 	"strings"
 	"testing"
 
 	"github.com/mongodb-labs/atlas-cli-plugin-terraform/internal/convert"
-	"github.com/sebdah/goldie/v2"
-	"github.com/spf13/afero"
-	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/require"
 )
 
 func TestClusterToAdvancedCluster(t *testing.T) {
-	const (
-		root        = "testdata/clu2adv"
-		inSuffix    = ".in.tf"
-		outSuffix   = ".out.tf"
-		errFilename = "errors.json"
-	)
-	fs := afero.NewOsFs()
-	errMap := make(map[string]string)
-	errContent, err := afero.ReadFile(fs, filepath.Join(root, errFilename))
-	require.NoError(t, err)
-	err = json.Unmarshal(errContent, &errMap)
-	require.NoError(t, err)
-	g := goldie.New(t,
-		goldie.WithFixtureDir(root),
-		goldie.WithNameSuffix(outSuffix))
-	pattern := filepath.Join(root, "*"+inSuffix)
-	inputFiles, err := afero.Glob(fs, pattern)
-	require.NoError(t, err)
-	assert.NotEmpty(t, inputFiles)
-	for _, inputFile := range inputFiles {
-		testName := strings.TrimSuffix(filepath.Base(inputFile), inSuffix)
-		t.Run(testName, func(t *testing.T) {
-			inConfig, err := afero.ReadFile(fs, inputFile)
-			require.NoError(t, err)
-			includeMoved := strings.Contains(testName, "includeMoved")
-			outConfig, err := convert.ClusterToAdvancedCluster(inConfig, includeMoved)
-			if err == nil {
-				g.Assert(t, testName, outConfig)
-			} else {
-				errMsg, found := errMap[testName]
-				assert.True(t, found, "error not found in file %s for test %s, errMsg: %v", errFilename, testName, err)
-				assert.Contains(t, err.Error(), errMsg)
-			}
-		})
-	}
+	runConvertTests(t, "clu2adv", func(testName string, inConfig []byte) ([]byte, error) {
+		includeMoved := strings.Contains(testName, "includeMoved")
+		return convert.ClusterToAdvancedCluster(inConfig, includeMoved)
+	})
 }

internal/convert/convert_test.go

@@ -0,0 +1,52 @@
+package convert_test
+
+import (
+	"encoding/json"
+	"path/filepath"
+	"strings"
+	"testing"
+
+	"github.com/sebdah/goldie/v2"
+	"github.com/spf13/afero"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+// runConvertTests runs common conversion tests with the given test directory and convert function
+func runConvertTests(t *testing.T, testDir string, convert func(testName string, inConfig []byte) ([]byte, error)) {
+	t.Helper()
+	const (
+		inSuffix    = ".in.tf"
+		outSuffix   = ".out.tf"
+		errFilename = "errors.json"
+	)
+	root := filepath.Join("testdata", testDir)
+	fs := afero.NewOsFs()
+	errMap := make(map[string]string)
+	errContent, err := afero.ReadFile(fs, filepath.Join(root, errFilename))
+	require.NoError(t, err)
+	err = json.Unmarshal(errContent, &errMap)
+	require.NoError(t, err)
+	g := goldie.New(t,
+		goldie.WithFixtureDir(root),
+		goldie.WithNameSuffix(outSuffix))
+	pattern := filepath.Join(root, "*"+inSuffix)
+	inputFiles, err := afero.Glob(fs, pattern)
+	require.NoError(t, err)
+	assert.NotEmpty(t, inputFiles)
+	for _, inputFile := range inputFiles {
+		testName := strings.TrimSuffix(filepath.Base(inputFile), inSuffix)
+		t.Run(testName, func(t *testing.T) {
+			inConfig, err := afero.ReadFile(fs, inputFile)
+			require.NoError(t, err)
+			outConfig, err := convert(testName, inConfig)
+			if err == nil {
+				g.Assert(t, testName, outConfig)
+			} else {
+				errMsg, found := errMap[testName]
+				assert.True(t, found, "error not found in file %s for test %s, errMsg: %v", errFilename, testName, err)
+				assert.Contains(t, err.Error(), errMsg)
+			}
+		})
+	}
+}