CLOUDP-230973: Changed 'string' to 'key=value' for StringToString (#52)

jeroenvervaeke · web-flow · commit 3dc974bec70a · 2024-02-21T17:03:39.000Z
diff --git a/cobra2snooty_test.go b/cobra2snooty_test.go
@@ -142,7 +142,7 @@ func TestGenDocs(t *testing.T) {
 	checkStringOmits(t, output, deprecatedCmd.Short)
 
 	// Verify that the text "This value defaults to" is not printed when the default value is provided to StringToStringP
-	checkStringContains(t, output, "* - -x, --stringtostring\n     - string\n     - false\n     - help message for flag stringtostring\n   *")
+	checkStringContains(t, output, "* - -x, --stringtostring\n     - key=value\n     - false\n     - help message for flag stringtostring\n   *")
 }
 
 func TestGenDocsNoHiddenParents(t *testing.T) {
diff --git a/flags.go b/flags.go
@@ -33,7 +33,7 @@ const (
 
 var (
 	varnameMap = map[string]string{
-		"stringToString": "string",
+		"stringToString": "key=value",
 	}
 )
 

Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,7 @@ func TestGenDocs(t *testing.T) {`
`142`	`142`	`checkStringOmits(t, output, deprecatedCmd.Short)`
`143`	`143`
`144`	`144`	`// Verify that the text "This value defaults to" is not printed when the default value is provided to StringToStringP`
`145`		`- checkStringContains(t, output, "* - -x, --stringtostring\n - string\n - false\n - help message for flag stringtostring\n *")`
	`145`	`+ checkStringContains(t, output, "* - -x, --stringtostring\n - key=value\n - false\n - help message for flag stringtostring\n *")`
`146`	`146`	`}`
`147`	`147`
`148`	`148`	`func TestGenDocsNoHiddenParents(t *testing.T) {`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ const (`
`33`	`33`
`34`	`34`	`var (`
`35`	`35`	`varnameMap = map[string]string{`
`36`		`- "stringToString": "string",`
	`36`	`+ "stringToString": "key=value",`
`37`	`37`	`}`
`38`	`38`	`)`
`39`	`39`