task: Update golangci-lint to 1.46.2 (#18)

Author: gssbzn

.github/workflows/pr.yml

@@ -19,7 +19,7 @@ jobs:
       - name: lint
         uses: golangci/[email protected]
         with:
-          version: v1.41.1
+          version: v1.46.2
 
   tests-on-unix:
     needs: golangci-lint # run after golangci-lint action to not produce duplicated errors

Makefile

@@ -1,7 +1,7 @@
 # A Self-Documenting Makefile: http://marmelab.com/blog/2016/02/29/auto-documented-makefile.html
 
 SOURCE_FILES?=./...
-GOLANGCI_VERSION=v1.41.1
+GOLANGCI_VERSION=v1.46.2
 COVERAGE=coverage.out
 
 export PATH := ./bin:$(PATH)

cobra2snooty_test.go

@@ -133,7 +133,7 @@ func TestGenDocsNoHiddenParents(t *testing.T) {
 	for _, name := range []string{"rootflag", "strtwo"} {
 		f := Root().PersistentFlags().Lookup(name)
 		f.Hidden = true
-		defer func() { f.Hidden = false }()
+		t.Cleanup(func() { f.Hidden = false })
 	}
 	buf := new(bytes.Buffer)
 	if err := GenDocs(Echo(), buf); err != nil {

flags.go

@@ -59,7 +59,7 @@ func FlagUsages(f *pflag.FlagSet) string {
 		if flag.NoOptDefVal != "" {
 			switch flag.Value.Type() {
 			case stringType:
-				line += fmt.Sprintf("[=\"%s\"]", flag.NoOptDefVal)
+				line += fmt.Sprintf("[=%q]", flag.NoOptDefVal)
 			case boolType:
 				if flag.NoOptDefVal != "true" {
 					line += fmt.Sprintf("[=%s]", flag.NoOptDefVal)