Skip to content

Commit 27bb9ed

Browse files
committed
Define context in caller runCompare
1 parent 8387e0c commit 27bb9ed

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

.evergreen/perfcomp/cmd/perfcomp/compare.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,15 @@
11
package main
22

33
import (
4+
"context"
45
"fmt"
56
"log"
67
"math"
78
"os"
89
"sort"
910
"strings"
1011
"text/tabwriter"
12+
"time"
1113

1214
"github.com/mongodb-labs/drivers-evergreen-tools/perfcomp"
1315
"github.com/spf13/cobra"
@@ -93,7 +95,10 @@ func runCompare(cmd *cobra.Command, args []string, project string, perfContext s
9395
perfAnalyzerConnString := os.Getenv("PERF_URI_PRIVATE_ENDPOINT")
9496
version := args[len(args)-1]
9597

96-
res, err := perfcomp.Compare(cmd.Context(), version, perfAnalyzerConnString, project, perfContext)
98+
ctx, cancel := context.WithTimeout(cmd.Context(), 5*time.Second)
99+
defer cancel()
100+
101+
res, err := perfcomp.Compare(ctx, version, perfAnalyzerConnString, project, perfContext)
97102
if err != nil {
98103
log.Fatalf("failed to compare: %v", err)
99104
}

.evergreen/perfcomp/compare.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -131,9 +131,6 @@ func Compare(ctx context.Context, versionID string, perfAnalyzerConnString strin
131131
}
132132
}()
133133

134-
ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
135-
defer cancel()
136-
137134
err = client.Ping(ctx, nil)
138135
if err != nil {
139136
return nil, fmt.Errorf("error pinging MongoDB Analytics: %v", err)

0 commit comments

Comments
 (0)