Actually fixed style, added tests, and added docstring note

Author: achawkins

flask_pymongo/__init__.py

@@ -214,8 +214,14 @@ def get_upload(filename):
         response.make_conditional(request)
         return response
 
-    def save_file(self, filename, fileobj, base="fs", content_type=None,
-        **kwargs):
+    def save_file(
+        self,
+        filename,
+        fileobj,
+        base="fs",
+        content_type=None,
+        **kwargs,
+    ):
         """Save a file-like object to GridFS using the given filename.
 
         .. code-block:: python
@@ -231,6 +237,7 @@ def save_upload(filename):
         :param str content_type: the MIME content-type of the file. If
            ``None``, the content-type is guessed from the filename using
            :func:`~mimetypes.guess_type`
+        :param **kwargs: extra attributes to be stored in the file's document
         """
         if not isinstance(base, text_type):
             raise TypeError("'base' must be string or unicode")
@@ -241,5 +248,9 @@ def save_upload(filename):
             content_type, _ = guess_type(filename)
 
         storage = GridFS(self.db, base)
-        return storage.put(fileobj, filename=filename,
-            content_type=content_type, **kwargs)
+        return storage.put(
+            fileobj,
+            filename=filename,
+            content_type=content_type,
+            **kwargs,
+        )

flask_pymongo/tests/test_gridfs.py

@@ -1,6 +1,7 @@
 from hashlib import md5
 from io import BytesIO
 
+from bson.objectid import ObjectId
 from gridfs import GridFS
 from werkzeug.exceptions import NotFound
 import pytest
@@ -38,6 +39,22 @@ def test_it_guesses_type_from_filename(self):
         gridfile = gridfs.find_one({"filename": "my-file.txt"})
         assert gridfile.content_type == "text/plain"
 
+    def test_it_saves_files_with_props(self):
+        fileobj = BytesIO(b"these are the bytes")
+
+        self.mongo.save_file("my-file", fileobj, foo="bar")
+
+        gridfs = GridFS(self.mongo.db)
+        gridfile = gridfs.find_one({"filename": "my-file"})
+        assert gridfile.foo == "bar"
+
+    def test_it_returns_id(self):
+        fileobj = BytesIO(b"these are the bytes")
+
+        _id = self.mongo.save_file("my-file", fileobj, foo="bar")
+
+        assert type(_id) is ObjectId
+
 
 class TestSendFile(GridFSCleanupMixin, FlaskPyMongoTest):