move defer

FGasper · FGasper · commit 140512badf71 · 2024-11-22T15:48:56.000-05:00
diff --git a/internal/verifier/change_stream.go b/internal/verifier/change_stream.go
@@ -179,8 +179,6 @@ func (verifier *Verifier) readAndHandleOneChangeEventBatch(
 }
 
 func (verifier *Verifier) iterateChangeStream(ctx context.Context, cs *mongo.ChangeStream) error {
-	defer cs.Close(ctx)
-
 	var lastPersistedTime time.Time
 
 	persistResumeTokenIfNeeded := func() error {
@@ -369,6 +367,8 @@ func (verifier *Verifier) StartChangeStream(ctx context.Context) error {
 						return err
 					}
 
+					defer srcChangeStream.Close(ctx)
+
 					if parentThreadWaiting {
 						resultChan <- mo.Ok(startTs)
 						close(resultChan)

Original file line number	Diff line number	Diff line change
`@@ -179,8 +179,6 @@ func (verifier *Verifier) readAndHandleOneChangeEventBatch(`
`179`	`179`	`}`
`180`	`180`
`181`	`181`	`func (verifier Verifier) iterateChangeStream(ctx context.Context, cs mongo.ChangeStream) error {`
`182`		`- defer cs.Close(ctx)`
`183`		`-`
`184`	`182`	`var lastPersistedTime time.Time`
`185`	`183`
`186`	`184`	`persistResumeTokenIfNeeded := func() error {`
`@@ -369,6 +367,8 @@ func (verifier *Verifier) StartChangeStream(ctx context.Context) error {`
`369`	`367`	`return err`
`370`	`368`	`}`
`371`	`369`
	`370`	`+ defer srcChangeStream.Close(ctx)`
	`371`	`+`
`372`	`372`	`if parentThreadWaiting {`
`373`	`373`	`resultChan <- mo.Ok(startTs)`
`374`	`374`	`close(resultChan)`