Revert "syncslice, too"

This reverts commit 0ab8341.

Author: FGasper

internal/verifier/compare.go

@@ -7,7 +7,6 @@ import (
 
 	"github.com/10gen/migration-verifier/internal/types"
 	"github.com/10gen/migration-verifier/syncmap"
-	"github.com/10gen/migration-verifier/syncslice"
 	"github.com/pkg/errors"
 	"go.mongodb.org/mongo-driver/bson"
 	"go.mongodb.org/mongo-driver/mongo"
@@ -67,9 +66,9 @@ func (verifier *Verifier) compareDocsFromChannels(
 	types.ByteCount,
 	error,
 ) {
-	results := syncslice.New[VerificationResult]()
-	var srcDocCount types.DocumentCount
-	var srcByteCount types.ByteCount
+	results := []VerificationResult{}
+	var docCount types.DocumentCount
+	var byteCount types.ByteCount
 
 	mapKeyFieldNames := make([]string, 1+len(task.QueryFilter.ShardKeys))
 	mapKeyFieldNames[0] = "_id"
@@ -132,7 +131,7 @@ func (verifier *Verifier) compareDocsFromChannels(
 			return errors.Wrap(err, "failed to compare documents")
 		}
 
-		results = results.Push(mismatches...)
+		results = append(results, mismatches...)
 
 		return nil
 	}
@@ -167,8 +166,8 @@ func (verifier *Verifier) compareDocsFromChannels(
 					srcClosed = true
 					break
 				}
-				srcDocCount++
-				srcByteCount += types.ByteCount(len(doc))
+				docCount++
+				byteCount += types.ByteCount(len(doc))
 
 				err := handleNewDoc(doc, true)
 
@@ -230,8 +229,12 @@ func (verifier *Verifier) compareDocsFromChannels(
 	// At this point, any documents left in the cache maps are simply
 	// missing on the other side. We add results for those.
 
+	// We might as well pre-grow the slice:
+	results = slices.Grow(results, srcCache.Len()+dstCache.Len())
+
 	srcCache.Range(func(_ string, doc bson.Raw) bool {
-		results = results.Push(
+		results = append(
+			results,
 			VerificationResult{
 				ID:        doc.Lookup("_id"),
 				Details:   Missing,
@@ -245,7 +248,8 @@ func (verifier *Verifier) compareDocsFromChannels(
 	})
 
 	dstCache.Range(func(_ string, doc bson.Raw) bool {
-		results = results.Push(
+		results = append(
+			results,
 			VerificationResult{
 				ID:        doc.Lookup("_id"),
 				Details:   Missing,
@@ -258,7 +262,7 @@ func (verifier *Verifier) compareDocsFromChannels(
 		return true
 	})
 
-	return results.Get(), srcDocCount, srcByteCount, nil
+	return results, docCount, byteCount, nil
 }
 
 func simpleTimerReset(t *time.Timer, dur time.Duration) {