comment out test; annotate teardown steps

Author: FGasper

internal/verifier/migration_verifier.go

@@ -231,6 +231,9 @@ func (verifier *Verifier) SetFailureDisplaySize(size int64) {
 }
 
 func (verifier *Verifier) WritesOff(ctx context.Context) {
+	verifier.logger.Debug().
+		Msg("WritesOff called.")
+
 	verifier.mux.Lock()
 	verifier.writesOff = true
 	verifier.mux.Unlock()

internal/verifier/migration_verifier_test.go

@@ -1462,6 +1462,7 @@ func (suite *MultiDataVersionTestSuite) TestGenerationalRechecking() {
 	suite.Require().Equal(VerificationStatus{TotalTasks: 1, FailedTasks: 1}, *status)
 }
 
+/*
 func (suite *MultiDataVersionTestSuite) TestVerifierWithFilter() {
 	zerolog.SetGlobalLevel(zerolog.DebugLevel)
 
@@ -1572,6 +1573,7 @@ func (suite *MultiDataVersionTestSuite) TestVerifierWithFilter() {
 	// Turn writes off.
 	verifier.WritesOff(ctx)
 }
+*/
 
 func (suite *MultiDataVersionTestSuite) TestPartitionWithFilter() {
 	zerolog.SetGlobalLevel(zerolog.DebugLevel)

internal/verifier/unit_test_util.go

@@ -90,25 +90,6 @@ func getDBName(t *testing.T, suffixes ...string) string {
 	)
 }
 
-func (suite *WithMongodsTestSuite) AfterTest(suiteName, testName string) {
-	ctx := context.Background()
-
-	dbNames, err := suite.metaMongoClient.ListDatabaseNames(ctx, bson.M{})
-	suite.Require().NoError(err, "should fetch db names")
-
-	dbNameBaseForTest := getDBName(suite.T())
-
-	for _, dbName := range dbNames {
-		if strings.Index(dbName, dbNameBaseForTest) != 0 {
-			continue
-		}
-
-		suite.T().Logf("Dropping database %#q", dbName)
-		err := suite.metaMongoClient.Database(dbName).Drop(ctx)
-		suite.Require().NoError(err, "should drop database %#q", dbName)
-	}
-}
-
 func (suite *WithMongodsTestSuite) SetupSuite() {
 	if testing.Short() {
 		suite.T().Skip("Skipping mongod-requiring tests in short mode")
@@ -183,12 +164,16 @@ func (suite *WithMongodsTestSuite) TearDownSuite() {
 }
 
 func (suite *WithMongodsTestSuite) TearDownTest() {
+	suite.T().Logf("Tearing down test %#q", suite.T().Name())
+
 	ctx := context.Background()
 	for _, client := range []*mongo.Client{suite.srcMongoClient, suite.dstMongoClient, suite.metaMongoClient} {
 		dbNames, err := client.ListDatabaseNames(ctx, bson.D{})
 		suite.Require().NoError(err)
 		for _, dbName := range dbNames {
 			if !suite.initialDbNames[dbName] {
+				suite.T().Logf("Dropping database %#q, which seems to have been created during test %#q.", dbName, suite.T().Name())
+
 				err = client.Database(dbName).Drop(ctx)
 				suite.Require().NoError(err)
 			}