Dave's review

Author: tdq45gj

internal/verifier/change_stream.go

@@ -90,10 +90,7 @@ func (verifier *Verifier) HandleChangeStreamEvents(ctx context.Context, batch []
 		}
 	}
 
-	verifier.mux.Lock()
-	defer verifier.mux.Unlock()
-
-	return verifier.insertRecheckDocsWhileLocked(ctx, dbNames, collNames, docIDs, dataSizes)
+	return verifier.insertRecheckDocs(ctx, dbNames, collNames, docIDs, dataSizes)
 }
 
 func (verifier *Verifier) GetChangeStreamFilter() []bson.D {

internal/verifier/recheck.go

@@ -42,16 +42,24 @@ func (verifier *Verifier) InsertFailedCompareRecheckDocs(
 		collNames[i] = collName
 	}
 
-	verifier.mux.Lock()
-	defer verifier.mux.Unlock()
-
-	return verifier.insertRecheckDocsWhileLocked(context.Background(),
-		dbNames, collNames, documentIDs, dataSizes)
+	return verifier.insertRecheckDocs(
+		context.Background(),
+		dbNames,
+		collNames,
+		documentIDs,
+		dataSizes,
+	)
 }
 
-func (verifier *Verifier) insertRecheckDocsWhileLocked(
+func (verifier *Verifier) insertRecheckDocs(
 	ctx context.Context,
-	dbNames []string, collNames []string, documentIDs []interface{}, dataSizes []int) error {
+	dbNames []string,
+	collNames []string,
+	documentIDs []interface{},
+	dataSizes []int,
+) error {
+	verifier.mux.Lock()
+	defer verifier.mux.Unlock()
 
 	generation, _ := verifier.getGenerationWhileLocked()
 

internal/verifier/recheck_test.go

@@ -333,9 +333,6 @@ func insertRecheckDocs(
 	documentIDs []any,
 	dataSizes []int,
 ) error {
-	verifier.mux.Lock()
-	defer verifier.mux.Unlock()
-
 	dbNames := make([]string, len(documentIDs))
 	collNames := make([]string, len(documentIDs))
 
@@ -344,5 +341,5 @@ func insertRecheckDocs(
 		collNames[i] = collName
 	}
 
-	return verifier.insertRecheckDocsWhileLocked(ctx, dbNames, collNames, documentIDs, dataSizes)
+	return verifier.insertRecheckDocs(ctx, dbNames, collNames, documentIDs, dataSizes)
 }