Skip to content

Commit 8dad68b

Browse files
committed
with REP-5306’s changes
1 parent 7c00276 commit 8dad68b

File tree

2 files changed

+6
-22
lines changed

2 files changed

+6
-22
lines changed

internal/verifier/change_stream_test.go

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -141,16 +141,12 @@ func (suite *IntegrationTestSuite) TestStartAtTimeNoChanges() {
141141
err = verifier.StartChangeStream(ctx)
142142
suite.Require().NoError(err)
143143
suite.Require().Equal(verifier.srcStartAtTs, origStartTs)
144-
verifier.changeStreamEnderChan <- struct{}{}
144+
verifier.changeStreamFinalTsChan <- *origStartTs
145145
<-verifier.changeStreamDoneChan
146146
suite.Require().Equal(verifier.srcStartAtTs, origStartTs)
147147
}
148148

149149
func (suite *IntegrationTestSuite) TestStartAtTimeWithChanges() {
150-
if suite.GetSrcTopology() == TopologySharded {
151-
suite.T().Skip("Skipping pending REP-5299.")
152-
}
153-
154150
verifier := suite.BuildVerifier()
155151
ctx, cancel := context.WithCancel(context.Background())
156152
defer cancel()
@@ -187,13 +183,13 @@ func (suite *IntegrationTestSuite) TestStartAtTimeWithChanges() {
187183
"session time after events should exceed the original",
188184
)
189185

190-
verifier.changeStreamEnderChan <- struct{}{}
186+
verifier.changeStreamFinalTsChan <- *postEventsSessionTime
191187
<-verifier.changeStreamDoneChan
192188

193-
suite.Assert().GreaterOrEqual(
194-
verifier.srcStartAtTs.Compare(*postEventsSessionTime),
195-
0,
196-
"verifier.srcStartAtTs should now meet or exceed our session timestamp",
189+
suite.Assert().Equal(
190+
*postEventsSessionTime,
191+
verifier.srcStartAtTs,
192+
"verifier.srcStartAtTs should now be our session timestamp",
197193
)
198194
}
199195

internal/verifier/migration_verifier_test.go

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1152,10 +1152,6 @@ func TestVerifierCompareIndexSpecs(t *testing.T) {
11521152
}
11531153

11541154
func (suite *IntegrationTestSuite) TestVerifierNamespaceList() {
1155-
if suite.GetSrcTopology() == TopologySharded {
1156-
suite.T().Skip("Skipping pending REP-5299.")
1157-
}
1158-
11591155
verifier := suite.BuildVerifier()
11601156
ctx := suite.Context()
11611157

@@ -1282,10 +1278,6 @@ func (suite *IntegrationTestSuite) TestVerificationStatus() {
12821278
}
12831279

12841280
func (suite *IntegrationTestSuite) TestGenerationalRechecking() {
1285-
if suite.GetSrcTopology() == TopologySharded {
1286-
suite.T().Skip("Skipping pending REP-5299.")
1287-
}
1288-
12891281
zerolog.SetGlobalLevel(zerolog.DebugLevel)
12901282
verifier := suite.BuildVerifier()
12911283
verifier.SetSrcNamespaces([]string{"testDb1.testColl1"})
@@ -1394,10 +1386,6 @@ func (suite *IntegrationTestSuite) TestGenerationalRechecking() {
13941386
}
13951387

13961388
func (suite *IntegrationTestSuite) TestVerifierWithFilter() {
1397-
if suite.GetSrcTopology() == TopologySharded {
1398-
suite.T().Skip("Skipping pending REP-5299.")
1399-
}
1400-
14011389
zerolog.SetGlobalLevel(zerolog.DebugLevel)
14021390

14031391
filter := map[string]any{"inFilter": map[string]any{"$ne": false}}

0 commit comments

Comments
 (0)