move NewEventRecorder

Author: FGasper

internal/verifier/check.go

@@ -156,10 +156,6 @@ func (verifier *Verifier) CheckDriver(ctx context.Context, filter map[string]any
 		verifier.phase = Idle
 	}()
 
-	// A “throwaway” EventRecorder so that any change events that arrive
-	// right away will have somewhere to be recorded.
-	verifier.generationEventRecorder = NewEventRecorder()
-
 	verifier.mux.RLock()
 	csRunning := verifier.changeStreamRunning
 	verifier.mux.RUnlock()

internal/verifier/migration_verifier.go

@@ -199,6 +199,10 @@ func NewVerifier(settings VerifierSettings) *Verifier {
 		changeStreamErrChan:   make(chan error),
 		changeStreamDoneChan:  make(chan struct{}),
 		readConcernSetting:    readConcern,
+
+		// This will get recreated once gen0 starts, but we want it
+		// here in case the change streams gets an event before then.
+		generationEventRecorder: NewEventRecorder(),
 	}
 }
 

internal/verifier/migration_verifier_test.go

@@ -58,7 +58,7 @@ func buildVerifier(t *testing.T, srcMongoInstance MongoInstance, dstMongoInstanc
 	//verifier.SetStartClean(true)
 	verifier.SetNumWorkers(3)
 	verifier.SetGenerationPauseDelayMillis(0)
-	//verifier.SetWorkerSleepDelayMillis(0)
+	verifier.SetWorkerSleepDelayMillis(1000)
 	require.Nil(t, verifier.SetMetaURI(context.Background(), "mongodb://localhost:"+metaMongoInstance.port))
 	require.Nil(t, verifier.SetSrcURI(context.Background(), "mongodb://localhost:"+srcMongoInstance.port))
 	require.Nil(t, verifier.SetDstURI(context.Background(), "mongodb://localhost:"+dstMongoInstance.port))