Skip to content

Commit b55cd15

Browse files
committed
comments
1 parent eb7746f commit b55cd15

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

internal/verifier/change_stream.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -223,9 +223,9 @@ func (verifier *Verifier) iterateChangeStream(ctx context.Context, cs *mongo.Cha
223223
return errors.Wrap(err, "failed to extract timestamp from change stream's resume token")
224224
}
225225

226-
// writesOffTs refers to a real event (i.e., not appendOplogNote),
227-
// so we need to TryNext() if curTs == writesOffTs.
228-
if curTs.After(writesOffTs) {
226+
// writesOffTs never refers to a real event,
227+
// so we can stop once curTs >= writesOffTs.
228+
if !curTs.Before(writesOffTs) {
229229
verifier.logger.Debug().
230230
Interface("currentTimestamp", curTs).
231231
Interface("writesOffTimestamp", writesOffTs).
@@ -351,6 +351,7 @@ func (verifier *Verifier) createChangeStream(
351351

352352
// StartChangeStream starts the change stream.
353353
func (verifier *Verifier) StartChangeStream(ctx context.Context) error {
354+
// Result seems a bit simpler than messing with 2 separate channels.
354355
resultChan := make(chan mo.Result[primitive.Timestamp])
355356

356357
go func() {

0 commit comments

Comments
 (0)