tweak not to require topology in env

Author: FGasper

.github/workflows/all.yml

@@ -70,4 +70,3 @@ jobs:
           MVTEST_SRC: ${{matrix.topology.srcConnStr}}
           MVTEST_DST: ${{matrix.topology.dstConnStr}}
           MVTEST_META: mongodb://localhost:27040
-          MVTEST_TOPOLOGY: ${{matrix.topology.name}}

internal/verifier/change_stream_test.go

@@ -147,7 +147,7 @@ func (suite *IntegrationTestSuite) TestStartAtTimeNoChanges() {
 }
 
 func (suite *IntegrationTestSuite) TestStartAtTimeWithChanges() {
-	if suite.GetTopology() == TopologySharded {
+	if suite.GetSrcTopology() == TopologySharded {
 		suite.T().Skip("Skipping pending REP-5299.")
 	}
 

internal/verifier/integration_test_suite.go

@@ -2,11 +2,11 @@ package verifier
 
 import (
 	"context"
-	"os"
 	"strings"
 
 	mapset "github.com/deckarep/golang-set/v2"
 	"github.com/pkg/errors"
+	"github.com/samber/lo"
 	"github.com/stretchr/testify/suite"
 	"go.mongodb.org/mongo-driver/bson"
 	"go.mongodb.org/mongo-driver/mongo"
@@ -23,8 +23,6 @@ const (
 	TopologySharded TestTopology = "sharded"
 )
 
-var knownTopologies = []TestTopology{TopologyReplset, TopologySharded}
-
 type IntegrationTestSuite struct {
 	suite.Suite
 	srcConnStr, dstConnStr, metaConnStr             string
@@ -120,20 +118,22 @@ func (suite *IntegrationTestSuite) TearDownTest() {
 	}
 }
 
-func (suite *IntegrationTestSuite) GetTopology() TestTopology {
-	rawTopology, found := os.LookupEnv(topologyEnvVar)
-
-	suite.Require().True(found, "Environment must contain %#q.", topologyEnvVar)
+func (suite *IntegrationTestSuite) GetSrcTopology() TestTopology {
+	hello := struct {
+		Msg string
+	}{}
 
-	topology := TestTopology(rawTopology)
+	resp := suite.srcMongoClient.Database("admin").RunCommand(
+		suite.Context(),
+		bson.D{{"hello", 1}},
+	)
 
-	suite.Require().Contains(
-		knownTopologies,
-		topology,
-		"%#q must be a known value.",
+	suite.Require().NoError(
+		resp.Decode(&hello),
+		"should fetch & decode hello",
 	)
 
-	return topology
+	return lo.Ternary(hello.Msg == "isdbgrid", TopologySharded, "")
 }
 
 func (suite *IntegrationTestSuite) BuildVerifier() *Verifier {

internal/verifier/migration_verifier_test.go

@@ -1149,7 +1149,7 @@ func TestVerifierCompareIndexSpecs(t *testing.T) {
 }
 
 func (suite *IntegrationTestSuite) TestVerifierNamespaceList() {
-	if suite.GetTopology() == TopologySharded {
+	if suite.GetSrcTopology() == TopologySharded {
 		suite.T().Skip("Skipping pending REP-5299.")
 	}
 
@@ -1279,7 +1279,7 @@ func (suite *IntegrationTestSuite) TestVerificationStatus() {
 }
 
 func (suite *IntegrationTestSuite) TestGenerationalRechecking() {
-	if suite.GetTopology() == TopologySharded {
+	if suite.GetSrcTopology() == TopologySharded {
 		suite.T().Skip("Skipping pending REP-5299.")
 	}
 
@@ -1391,7 +1391,7 @@ func (suite *IntegrationTestSuite) TestGenerationalRechecking() {
 }
 
 func (suite *IntegrationTestSuite) TestVerifierWithFilter() {
-	if suite.GetTopology() == TopologySharded {
+	if suite.GetSrcTopology() == TopologySharded {
 		suite.T().Skip("Skipping pending REP-5299.")
 	}