REP-5277 Parallelize persistence of rechecks. #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdq45gj
approved these changes
Nov 14, 2024
| // This will split the given slice into *roughly* the given number of chunks. | ||
| // It may end up being more or fewer, but it should be pretty close. | ||
| func splitToChunks[T any, Slice ~[]T](elements Slice, numChunks int) []Slice { | ||
| elsPerChunk := len(elements) / numChunks |
Collaborator
There was a problem hiding this comment.
can we check numChunks > 0?
jtcovan
approved these changes
Nov 14, 2024
| DataSize: dataSizes[i], | ||
| } | ||
| for _, curThreadIndexes := range indexesPerThread { | ||
| curThreadIndexes := curThreadIndexes |
Collaborator
There was a problem hiding this comment.
Why do we redefine the var?
Collaborator
Author
There was a problem hiding this comment.
The linter flagged it as one of those cases where you’re supposed to redefine the var to prevent loop-variable-in-goroutine problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We receive events and enqueue rechecks in the same thread. When there are 1,000s of rechecks to enqueue at once, though, we need faster throughput than a single thread will allow.
This changeset fixes that by parallelizing the enqueueing of rechecks.