REP-5337 Flush mongos router configs. #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdq45gj
approved these changes
Dec 3, 2024
Collaborator
tdq45gj
left a comment
tdq45gj
left a comment
There was a problem hiding this comment.
LGTM other than the error message.
Co-authored-by: Jian Guan <[email protected]>
FGasper
added a commit
that referenced
this pull request
Dec 4, 2024
PR #64 introduced a bug where it would try to refresh mongoses regardless of server version. This fixes that by only refreshing mongoses for pre-v5 server versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This accommodates SERVER-32198 by:
a) flushing all mongos configs whenever it connects to a pre-v5 sharded cluster
b) forbidding SRV connection strings for pre-v5 clusters