Skip to content

Commit 76f5525

Browse files
authored
ARROW-121 Ensure libbson is built in Release Mode (#97)
* ARROW-121 Ensure libbson is built in Release Mode * address review * add changelog
1 parent a20b3b5 commit 76f5525

File tree

4 files changed

+10
-3
lines changed

4 files changed

+10
-3
lines changed

bindings/python/build-libbson.sh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ echo "Installing libbson..."
2323

2424
MACOSX_DEPLOYMENT_TARGET=${MACOSX_DEPLOYMENT_TARGET:-"10.15"}
2525
CMAKE_OSX_ARCHITECTURES=${CMAKE_OSX_ARCHITECTURES:-"x86_64"}
26+
CMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE:-"Debug"}
2627

2728
# Directory where build artifacts will be placed
2829
LIBBSON_INSTALL_DIR=${LIBBSON_INSTALL_DIR:-""}
@@ -44,18 +45,20 @@ pushd "$WORKDIR"
4445
cmake -DENABLE_AUTOMATIC_INIT_AND_CLEANUP=OFF \
4546
-DENABLE_MONGOC=OFF \
4647
-DCMAKE_OSX_ARCHITECTURES=${CMAKE_OSX_ARCHITECTURES} \
48+
-DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} \
4749
-DCMAKE_OSX_DEPLOYMENT_TARGET=${CMAKE_OSX_DEPLOYMENT_TARGET} \
4850
-DCMAKE_INSTALL_PREFIX:PATH="$LIBBSON_INSTALL_DIR" \
4951
..
5052
else
5153
cmake -DENABLE_AUTOMATIC_INIT_AND_CLEANUP=OFF \
5254
-DCMAKE_OSX_ARCHITECTURES=${CMAKE_OSX_ARCHITECTURES} \
55+
-DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} \
5356
-DCMAKE_OSX_DEPLOYMENT_TARGET=${CMAKE_OSX_DEPLOYMENT_TARGET} \
5457
-DENABLE_MONGOC=OFF \
5558
..
5659
fi
5760
cmake --build . --target clean
5861
cmake --build .
59-
cmake --build . --target install
62+
cmake --build . --target install --config ${CMAKE_BUILD_TYPE}
6063
popd
6164
popd

bindings/python/cibw_before_build.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,4 +23,4 @@ then
2323
fi
2424

2525
# Build libbson with the appropriate arch.
26-
./build-libbson.sh
26+
CMAKE_BUILD_TYPE=Release ./build-libbson.sh

bindings/python/docs/source/changelog.rst

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
Changelog
22
=========
33

4+
Changes in Version 0.6.0
5+
------------------------
6+
- Fixed ``ImportError`` on Windows by building ``libbson`` in "Release" mode.
7+
48
Changes in Version 0.5.1
59
------------------------
610
- Fixed auto-discovery of schemas for aggregation and ``numpy`` methods.

bindings/python/release.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ fi
2424
LIBBSON_INSTALL_DIR="$(pwd)/libbson"
2525

2626
# Build libbson
27-
LIBBSON_INSTALL_DIR="$LIBBSON_INSTALL_DIR" LIBBSON_VERSION=${LIBBSON_VERSION:-""} ./build-libbson.sh
27+
LIBBSON_INSTALL_DIR="$LIBBSON_INSTALL_DIR" LIBBSON_VERSION=${LIBBSON_VERSION:-""} CMAKE_BUILD_TYPE=Release ./build-libbson.sh
2828

2929
# Print Python version used
3030
$PYTHON --version

0 commit comments

Comments
 (0)