ARROW-120 Support PyArrow 10.0 (#99)

* ARROW-120 Support PyArrow 10.0

* bump to c++17

* build with macos 11 and add changelog

* update macos builds again

* try a windows fix

* fix macos deployment target again

* set macos deployment target default in setup.py as well

* address review

* clarify

Author: blink1073

.github/workflows/release-python.yml

@@ -25,7 +25,7 @@ jobs:
         # https://github.com/github/feedback/discussions/7835#discussioncomment-1769026
         buildplat:
         - [ubuntu-20.04, manylinux_x86_64]
-        - [macos-10.15, macosx_*]
+        - [macos-11, macosx_*]
         - [windows-2019, win_amd64]
         python: ["cp37", "cp38", "cp39", "cp310"]
 
@@ -41,17 +41,17 @@ jobs:
         run: python -m pip install "cibuildwheel>=2.4,<3"
 
       - name: Build MacOS Py38 Wheel
-        if: ${{ matrix.python == 'cp38' && matrix.buildplat[0] == 'macos-10.15' }}
+        if: ${{ matrix.python == 'cp38' && matrix.buildplat[0] == 'macos-11' }}
         env:
           CIBW_BUILD: cp38-macosx_x86_64
-          MACOSX_DEPLOYMENT_TARGET: "10.13"
+          MACOSX_DEPLOYMENT_TARGET: "10.14"
         run: python -m cibuildwheel --output-dir wheelhouse
 
       - name: Build wheels
-        if: ${{ matrix.python != 'cp38' || matrix.buildplat[0] != 'macos-10.15' }}
+        if: ${{ matrix.python != 'cp38' || matrix.buildplat[0] != 'macos-11' }}
         env:
           CIBW_BUILD: ${{ matrix.python }}-${{ matrix.buildplat[1] }}
-          MACOSX_DEPLOYMENT_TARGET: "10.13"
+          MACOSX_DEPLOYMENT_TARGET: "10.14"
         run: python -m cibuildwheel --output-dir wheelhouse
 
       - uses: actions/upload-artifact@v3

bindings/python/build-libbson.sh

@@ -46,14 +46,14 @@ pushd "$WORKDIR"
             -DENABLE_MONGOC=OFF \
             -DCMAKE_OSX_ARCHITECTURES=${CMAKE_OSX_ARCHITECTURES} \
             -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} \
-            -DCMAKE_OSX_DEPLOYMENT_TARGET=${CMAKE_OSX_DEPLOYMENT_TARGET} \
+            -DCMAKE_OSX_DEPLOYMENT_TARGET=${MACOSX_DEPLOYMENT_TARGET} \
             -DCMAKE_INSTALL_PREFIX:PATH="$LIBBSON_INSTALL_DIR" \
             ..
     else
       cmake -DENABLE_AUTOMATIC_INIT_AND_CLEANUP=OFF \
             -DCMAKE_OSX_ARCHITECTURES=${CMAKE_OSX_ARCHITECTURES} \
             -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} \
-            -DCMAKE_OSX_DEPLOYMENT_TARGET=${CMAKE_OSX_DEPLOYMENT_TARGET} \
+            -DCMAKE_OSX_DEPLOYMENT_TARGET=${MACOSX_DEPLOYMENT_TARGET} \
             -DENABLE_MONGOC=OFF \
             ..
     fi

bindings/python/docs/source/changelog.rst

@@ -4,6 +4,7 @@ Changelog
 Changes in Version 0.6.0
 ------------------------
 - Fixed ``ImportError`` on Windows by building ``libbson`` in "Release" mode.
+- Support PyArrow 10.0.
 
 Changes in Version 0.5.1
 ------------------------

bindings/python/pyproject.toml

@@ -4,7 +4,7 @@ requires = [
     "wheel>=0.37",
     "cython>=0.29",
     # Must be kept in sync with the `install_requires` in `setup.cfg`
-    "pyarrow>=9.0.0,<9.1.0",
+    "pyarrow>=10.0.0,<10.1.0",
 ]
 
 [tool.cibuildwheel]

bindings/python/setup.cfg

@@ -34,7 +34,7 @@ packages = find:
 python_requires = >=3.7
 install_requires =
     # keep versions in sync with pyproject.toml "requires"
-    pyarrow >=9,<9.1
+    pyarrow >=10,<10.1
     pymongo >=3.11,<5
 
 [options.package_data]

bindings/python/setup.py

@@ -18,6 +18,9 @@
 # Whether to create libarrow symlinks on posix systems.
 CREATE_LIBARROW_SYMLINKS = os.environ.get("MONGO_CREATE_LIBARROW_SYMLINKS", "1")
 
+# Set a default value for MACOSX_DEPLOYMENT_TARGET.
+os.environ.setdefault("MACOSX_DEPLOYMENT_TARGET", "10.15")
+
 
 def query_pkgconfig(cmd):
     status, output = subprocess.getstatusoutput(cmd)
@@ -147,14 +150,16 @@ def append_arrow_flags(ext):
         pa.create_library_symlinks()
 
     if os.name == "posix":
-        ext.extra_compile_args.append("-std=c++11")
-
-    # Arrow's manylinux{2010, 2014} binaries are built with gcc < 4.8 which predates CXX11 ABI
-    # - https://uwekorn.com/2019/09/15/how-we-build-apache-arrows-manylinux-wheels.html
-    # - https://arrow.apache.org/docs/python/extending.html#example
-    if "std=" not in os.environ.get("CXXFLAGS", ""):
-        ext.extra_compile_args.append("-std=c++11")
-        ext.extra_compile_args.append("-D_GLIBCXX_USE_CXX11_ABI=0")
+        ext.extra_compile_args.append("-std=c++17")
+
+        # Arrow's manylinux{2010, 2014} binaries are built with gcc < 4.8 which predates CXX11 ABI
+        # - https://uwekorn.com/2019/09/15/how-we-build-apache-arrows-manylinux-wheels.html
+        # - https://arrow.apache.org/docs/python/extending.html#example
+        if "std=" not in os.environ.get("CXXFLAGS", ""):
+            ext.extra_compile_args.append("-D_GLIBCXX_USE_CXX11_ABI=0")
+
+    elif os.name == "nt":
+        ext.extra_compile_args.append("/std:c++17")
 
 
 def get_extension_modules():