Skip to content

Conversation

NoahStapp
Copy link
Collaborator

No description provided.

@@ -0,0 +1,62 @@
"""Tests for CRUD utilities."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong docstring?

@NoahStapp NoahStapp requested a review from blink1073 September 10, 2025 11:21
"reciprocal_rank_stage",
"final_hybrid_stage",
"bulk_embed_and_insert_texts",
"str_to_oid",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to export these two

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we expect to use bulk_embed_and_insert_texts? Or do you mean the two str_to_oid and oid_to_str?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

str_to_oid and oid_to_str

@NoahStapp NoahStapp requested a review from blink1073 September 10, 2025 12:57
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@NoahStapp NoahStapp merged commit 62a5c5f into mongodb-labs:main Sep 10, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants