From 4475f29efa29f1473d9926e72151be393ceb5aef Mon Sep 17 00:00:00 2001 From: Jib Date: Thu, 25 Sep 2025 13:57:53 -0400 Subject: [PATCH 1/4] PYTHON-5583: Add Pull Request template MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [PYTHON-5583](https://jira.mongodb.org/browse/PYTHON-5583) ## Summary Adds a Pull Request template to this repository based on our new dbx-python code review policy. ## Changes in this PR * PULL_REQUEST_TEMPLATE.md ## Test Plan Make a PR from this branch to confirm ### Screenshots (optional) ## Checklist ### Checklist for Author - [x] Did you update the changelog (if necessary)? **Not necessary** - [x] Is the intention of the code captured in relevant tests? **Not necessary** - [x] If there are new TODOs, has a related JIRA ticket been created? **Not necessary** ### Checklist for Reviewer [@NoahStapp] - [ ] Does the title of the PR reference a JIRA Ticket? - [ ] Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?) - [ ] Have you checked for spelling & grammar errors? - [ ] Is all relevant documentation (README or docstring) updated? ## Focus Areas for Reviewer For reviewers provide suggestions on what should be changed about the checklist to better cater to this repository. --- .github/PULL_REQUEST_TEMPLATE.md | 50 ++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 0000000..d1441a9 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,50 @@ +[Issue Key](https://jira.mongodb.org/browse/{ISSUE_KEY}) + + +## Summary + +## Changes in this PR + + + + + +## Test Plan + + + + + +### Screenshots (optional) + + + + + +## Checklist + + + + + +### Checklist for Author + + +- [ ] Did you update the changelog (if necessary)? +- [ ] Is the intention of the code captured in relevant tests? +- [ ] If there are new TODOs, has a related JIRA ticket been created? + + +### Checklist for Reviewer {@primary\_reviewer} + + +- [ ] Does the title of the PR reference a JIRA Ticket? +- [ ] Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?) +- [ ] Have you checked for spelling & grammar errors? +- [ ] Is all relevant documentation (README or docstring) updated? + + +## Focus Areas for Reviewer + + + From b8c68cfafac18dab11cf6c49b541f2e799eafd16 Mon Sep 17 00:00:00 2001 From: Jib Date: Mon, 29 Sep 2025 12:01:06 -0400 Subject: [PATCH 2/4] Reformatted PR template --- .github/PULL_REQUEST_TEMPLATE.md | 28 ++++++++-------------------- 1 file changed, 8 insertions(+), 20 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index d1441a9..e4516e4 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,50 +1,38 @@ [Issue Key](https://jira.mongodb.org/browse/{ISSUE_KEY}) - ## Summary + -## Changes in this PR +## Changes in this PR - ## Test Plan - - ### Screenshots (optional) - - ## Checklist - - ### Checklist for Author - -- [ ] Did you update the changelog (if necessary)? -- [ ] Is the intention of the code captured in relevant tests? +- [ ] Did you update the changelog (if necessary)? +- [ ] Is the intention of the code captured in relevant tests? - [ ] If there are new TODOs, has a related JIRA ticket been created? +### Checklist for Reviewer {@primary_reviewer} -### Checklist for Reviewer {@primary\_reviewer} - - -- [ ] Does the title of the PR reference a JIRA Ticket? -- [ ] Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?) -- [ ] Have you checked for spelling & grammar errors? +- [ ] Does the title of the PR reference a JIRA Ticket? +- [ ] Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?) +- [ ] Have you checked for spelling & grammar errors? - [ ] Is all relevant documentation (README or docstring) updated? - ## Focus Areas for Reviewer - From 9852d33d1fee01bd67cc0d2bb0f373a459f2c0d0 Mon Sep 17 00:00:00 2001 From: Jib Date: Mon, 29 Sep 2025 12:09:38 -0400 Subject: [PATCH 3/4] Lint fixes --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index e4516e4..5c958e1 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,4 +1,4 @@ -[Issue Key](https://jira.mongodb.org/browse/{ISSUE_KEY}) +[Issue Key](https://jira.mongodb.org/browse/%7ISSUE_KEY%7D) ## Summary From f296a5203342a3279fce3806325fb02e734c56a6 Mon Sep 17 00:00:00 2001 From: Jib Date: Mon, 29 Sep 2025 12:23:58 -0400 Subject: [PATCH 4/4] Update .github/PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 5c958e1..a9131f2 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,4 +1,4 @@ -[Issue Key](https://jira.mongodb.org/browse/%7ISSUE_KEY%7D) +[Issue Key](https://jira.mongodb.org/browse/%7BISSUE_KEY%7D) ## Summary