chore: Fixes new-version.sh to avoid accidentally overwriting version variables when calling breaking-changes script (#519)

Author: EspenAlbert

internal/core/version.go

@@ -5,7 +5,7 @@ package core
 // For more information please see: https://github.com/mongodb/atlas-sdk-go/blob/main/docs/doc_1_concepts.md
 const (
 	// SDK release tag version.
-	Version = "v20241113005.0.0"
+	Version = "v20250219001.0.0"
 	// Resource Version.
 	Resource = "20250219"
 )

tools/releaser/scripts/breaking-changes.sh

@@ -5,9 +5,26 @@ set -eu
 TARGET_BREAKING_CHANGES_FILE=${TARGET_BREAKING_CHANGES_FILE:-""}
 script_path=$(dirname "$0")
 
-# shellcheck source=/dev/null
-source "$script_path/extract-version.sh"
-BASE_VERSION="github.com/mongodb/atlas-sdk-go/$SDK_MAJOR_VERSION@$SDK_VERSION"
+baseVersion() {
+	local base_version
+    # Create an isolated subshell to contain the sourcing to avoid overwritting version vars
+	base_version=$(
+        {
+			# shellcheck source=/dev/null
+            source "$script_path/extract-version.sh" >&2
+            # Output only the variable we want
+            echo "github.com/mongodb/atlas-sdk-go/$SDK_MAJOR_VERSION@$SDK_VERSION"
+        }
+    )
+    local ret_val=$?
+    if [ $ret_val -ne 0 ]; then
+        echo "Error when sourcing extract-version.sh" >&2
+        return $ret_val
+    fi
+    export BASE_VERSION="$base_version"
+}
+
+baseVersion
 
 echo "Installing gorelease"
 go install golang.org/x/exp/cmd/gorelease@latest >/dev/null