Skip to content

Commit 7a40092

Browse files
authored
chore: Fix SDK preview linter issues (#612)
1 parent 6b12a4b commit 7a40092

File tree

4 files changed

+5
-7
lines changed

4 files changed

+5
-7
lines changed

.github/workflows/autoupdate-preview.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@ jobs:
4040
working-directory: ./tools
4141
if: env.FILES_CHANGED == 'true'
4242
run: make generate_mocks
43+
- name: Fix import order issues
44+
run: goimports -l -w .
4345
- uses: peter-evans/create-pull-request@271a8d0340265f705b14b6d32b9829c1cb33d45e
4446
if: env.FILES_CHANGED == 'true'
4547
with:

.github/workflows/pr.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ jobs:
3939
run: |
4040
npm install
4141
npm run ci
42-
- run: go install golang.org/x/tools/cmd/goimports@v0.21.0
42+
- run: make install-goimports
4343
- working-directory: ./tools
4444
run: |
4545
export PATH=${PATH}:`go env GOPATH`/bin

Makefile

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
SOURCE_FILES?=./...
22
GOLANGCI_VERSION=v2.1.6 # Also update golangci-lint GH action in pr.yml when updating this version
33

4-
GOIMPORTS_VERSION=v0.21.0
5-
COVERAGE=coverage.out
6-
74
export GO111MODULE := on
85
export PATH := ./bin:$(PATH)
96

@@ -20,7 +17,7 @@ build:
2017

2118
.PHONY: test
2219
test:
23-
go test $(SOURCE_FILES) -coverprofile $(COVERAGE) -timeout=30s -parallel=4 -cover -race
20+
go test $(SOURCE_FILES) -timeout=30s -parallel=4 -race
2421

2522
.PHONY: test-examples
2623
test-examples:
@@ -48,7 +45,7 @@ install-golangci-lint:
4845

4946
.PHONY: install-goimports
5047
install-goimports:
51-
go install golang.org/x/tools/cmd/goimports@$(GOIMPORTS_VERSION)
48+
go install golang.org/x/tools/cmd/goimports@latest
5249

5350
.PHONY: tools
5451
tools: install-golangci-lint install-goimports

tools/releaser/scripts/preview-version.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,3 @@ npm exec -c "replace-in-file '/$OLD_PACKAGE/g' '$NEW_PACKAGE' $VERSION_UPDATE_PA
2020

2121
echo "Add preview version to examples go.mod"
2222
(cd "$examples_path" && go get $NEW_PACKAGE)
23-

0 commit comments

Comments
 (0)