File tree Expand file tree Collapse file tree 2 files changed +8
-4
lines changed Expand file tree Collapse file tree 2 files changed +8
-4
lines changed Original file line number Diff line number Diff line change 7575 ## Manual Review Procedure
7676
7777 1. Review changes in the OpenAPI file (openapi/atlas-api.yaml)
78- 2. Review breaking changes information in generated `./releaser/breaking_changes/{release_version}.md` file
79- 3. Merge PR into the main branch
78+ 2. If PR contains breaking changes, review `./releaser/breaking_changes/{release_version}.md` file
79+ 3. Approve and merge PR into the main branch
8080 4. After the merge automated release process will be triggered.
8181
8282
Original file line number Diff line number Diff line change 11#! /bin/bash
22set +e
3+ set +u
34GOPATH=$( go env GOPATH)
45
56# Inputs:
@@ -14,7 +15,10 @@ go install github.com/joelanford/go-apidiff@latest > /dev/null
1415GIT_BASE_REF=${GIT_BASE_REF:- git rev-parse head || echo}
1516
1617echo " Running breaking changes check for $GIT_BASE_REF "
17- BREAKING_CHANGES=$( " $GOPATH /bin/go-apidiff" " $GIT_BASE_REF " --compare-imports=" false" --print-compatible=" false" --repo-path=" ../" )
18+
19+ pushd " $script_path /../../../" || exit # # workaround for --repo-path="../" not working
20+ BREAKING_CHANGES=$( " $GOPATH /bin/go-apidiff" " $GIT_BASE_REF " --compare-imports=" false" --print-compatible=" false" )
21+ popd || exit
1822
1923if [ -z " $BREAKING_CHANGES " ]; then
2024 echo " No breaking changes detected"
2428 echo " $BREAKING_CHANGES "
2529 else
2630 echo " Creating breaking changes file"
27- echo -e " # Breaking Changes \n ## SDK changes\n$BREAKING_CHANGES \n## API Changelog\n https://www.mongodb.com/docs/atlas/reference/api-resources-spec/changelog" \
31+ echo -e " # Breaking Changes\n ## SDK changes\n$BREAKING_CHANGES \n## API Changelog\n https://www.mongodb.com/docs/atlas/reference/api-resources-spec/changelog" \
2832 > " $script_path /../breaking_changes/${TARGET_BREAKING_CHANGES_FILE} .md"
2933 fi
3034fi
You can’t perform that action at this time.
0 commit comments