Skip to content

Commit 0b7cea0

Browse files
authored
INTMDB-800: update field descriptions for CfnDatabaseUser (#57)
1 parent f44d4b6 commit 0b7cea0

File tree

5 files changed

+69
-65
lines changed

5 files changed

+69
-65
lines changed

API.md

Lines changed: 13 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

TESTING.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,24 +21,24 @@ MongoDB::Atlas::AlertConfiguration \
2121
--execution-role-arn <role-arn>
2222
```
2323
### Running unit tests:
24-
5. Ensure unit tests for each resource (located in `[resource-folder]/test/index.test.ts)` are updated and successful.
24+
5. Ensure unit tests for each resource (located in `/test/[resource-folder]/index.test.ts)` are updated and successful.
2525
- Run unit tests with `npx projen test` inside the resource folder
2626
```
2727
# if you created an L1 resource
28-
cd cdk/cdk-resouces/[resource-folder]
28+
cd test/l1-resources/[resource-folder]
2929
3030
# if you created an L2 resource
31-
cd cdk/l2-cdk-resources/[resource-folder]
31+
cd test/l2-resources/[resource-folder]
3232
3333
# if you created an L3 resource
34-
cd cdk/l3-cdk-resources/[resource-folder]
34+
cd test/l3-resources/[resource-folder]
3535
3636
npx projen test
3737
```
3838

3939
## Testing the resource in a CFN stack:
40-
1. Build the construct by running `npx projen build` inside the `[resource-folder]`.
41-
2. Navigate inside `/[resource-folder]/dist/js` and copy the`.tgz` file. You will use this in the next steps.
40+
1. Build the construct by running `npx projen build`.
41+
2. Navigate inside `/dist/js` and copy the`.tgz` file. You will use this in the next steps.
4242
3. Create a CDK test app: We will be using a CDK app to test our construct by using the app to create, update and delete AWS CloudFormation stacks.
4343
Create the CDK app by running the following in a terminal: ([refer AWS walkthrough for details](https://docs.aws.amazon.com/cdk/v2/guide/hello_world.html#hello_world_tutorial_create_app)):
4444
```

src/l1-resources/database-user/index.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,14 @@ export interface CfnDatabaseUserProps {
1616
readonly deleteAfterDate?: string;
1717

1818
/**
19-
* Human-readable label that indicates whether the new database user authenticates with the Amazon Web Services (AWS) Identity and Access Management (IAM) credentials associated with the user or the user's role.
19+
* Human-readable label that indicates whether the new database user authenticates with the Amazon Web Services (AWS) Identity and Access Management (IAM) credentials associated with the user or the user's role. Default value is `NONE`.
2020
*
2121
* @schema CfnDatabaseUserProps#AWSIAMType
2222
*/
2323
readonly awsiamType?: CfnDatabaseUserPropsAwsiamType;
2424

2525
/**
26-
* MongoDB database against which the MongoDB database user authenticates. MongoDB database users must provide both a username and authentication database to log into MongoDB.
26+
* MongoDB database against which the MongoDB database user authenticates. MongoDB database users must provide both a username and authentication database to log into MongoDB. Default value is `admin`.
2727
*
2828
* @schema CfnDatabaseUserProps#DatabaseName
2929
*/
@@ -37,14 +37,14 @@ export interface CfnDatabaseUserProps {
3737
readonly labels?: LabelDefinition[];
3838

3939
/**
40-
* Method by which the provided username is authenticated. If no value is given, Atlas uses the default value of NONE.
40+
* Method by which the provided username is authenticated. Default value is `NONE`.
4141
*
4242
* @schema CfnDatabaseUserProps#LdapAuthType
4343
*/
4444
readonly ldapAuthType?: CfnDatabaseUserPropsLdapAuthType;
4545

4646
/**
47-
* Method that briefs who owns the certificate provided. If no value is given while using X509Type, Atlas uses the default value of MANAGED.
47+
* Method that briefs who owns the certificate provided. Default value is `NONE`.
4848
*
4949
* @schema CfnDatabaseUserProps#X509Type
5050
*/
@@ -58,7 +58,7 @@ export interface CfnDatabaseUserProps {
5858
readonly password?: string;
5959

6060
/**
61-
* Unique identifier of the Atlas project to which the user belongs.
61+
* Unique 24-hexadecimal digit string that identifies your Atlas Project.
6262
*
6363
* @schema CfnDatabaseUserProps#ProjectId
6464
*/
@@ -79,14 +79,14 @@ export interface CfnDatabaseUserProps {
7979
readonly scopes?: ScopeDefinition[];
8080

8181
/**
82-
* Human-readable label that represents the user that authenticates to MongoDB.
82+
* Human-readable label that represents the user that authenticates to MongoDB. The format of this label depends on the method of authentication. This will be USER_ARN or ROLE_ARN if AWSIAMType is USER or ROLE. Refer https://www.mongodb.com/docs/atlas/reference/api-resources-spec/#tag/Database-Users/operation/createDatabaseUser for details.
8383
*
8484
* @schema CfnDatabaseUserProps#Username
8585
*/
8686
readonly username: string;
8787

8888
/**
89-
* Profile used to provide credentials information, (a secret with the cfn/atlas/profile/{Profile}, is required), if not provided default is used
89+
* Profile used to provide credentials information, (a secret with the cfn/atlas/profile/{Profile}, is required), if not provided `default` is used
9090
*
9191
* @schema CfnDatabaseUserProps#Profile
9292
*/
@@ -177,7 +177,7 @@ export function toJson_LabelDefinition(
177177
/* eslint-enable max-len, quote-props */
178178

179179
/**
180-
* Method by which the provided username is authenticated. If no value is given, Atlas uses the default value of NONE.
180+
* Method by which the provided username is authenticated. Default value is `NONE`.
181181
*
182182
* @schema CfnDatabaseUserPropsLdapAuthType
183183
*/
@@ -191,7 +191,7 @@ export enum CfnDatabaseUserPropsLdapAuthType {
191191
}
192192

193193
/**
194-
* Method that briefs who owns the certificate provided. If no value is given while using X509Type, Atlas uses the default value of MANAGED.
194+
* Method that briefs who owns the certificate provided. Default value is `NONE`.
195195
*
196196
* @schema CfnDatabaseUserPropsX509Type
197197
*/

src/l3-resources/atlas-basic-private-endpoint/index.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ export interface AtlasBasicPrivateEndpointProps {
7979
readonly profile?: string;
8080

8181
/**
82-
* @description
82+
* @description AWS Region
8383
* @type {string}
8484
* @default us-east-1
8585
* @memberof AtlasPrivateEndpointProps
@@ -106,25 +106,25 @@ export interface AtlasBasicPrivateEndpointProps {
106106
*/
107107
export interface PrivateEndpointProps {
108108
/**
109-
* @description
109+
* @description Name of the AWS PrivateLink endpoint service. Atlas returns null while it is creating the endpoint service.
110110
* @type {string}
111111
* @memberof PrivateEndpointProps
112112
*/
113113
readonly endpointServiceName?: string;
114114
/**
115-
* @description
115+
* @description Error message pertaining to the AWS PrivateLink connection. Returns null if there are no errors.
116116
* @type {string}
117117
* @memberof PrivateEndpointProps
118118
*/
119119
readonly errorMessage?: string;
120120
/**
121-
* @description
121+
* @description Status of the Atlas PrivateEndpoint service connection
122122
* @type {string}
123123
* @memberof PrivateEndpointProps
124124
*/
125125
readonly status?: string;
126126
/**
127-
* @description
127+
* @description Unique 24-hexadecimal digit string that identifies your project.
128128
* @type {string}
129129
* @memberof PrivateEndpointProps
130130
*/

0 commit comments

Comments
 (0)