fix: Fixes trigger attributes name and type that are required but were as optional (#226)

Author: lantoli

API.md

@@ -1,7 +1,7 @@
 // This example creates a database user in Atlas using the L1 resources.
 import * as cdk from 'aws-cdk-lib';
 import { Construct } from 'constructs';
-import { CfnTrigger,  DatabaseConfigOperationTypes } from 'awscdk-resources-mongodbatlas';
+import { CfnTrigger, DatabaseConfigOperationTypes } from 'awscdk-resources-mongodbatlas';
 
 interface AtlasStackProps {
   readonly projId: string;
@@ -23,6 +23,7 @@ export class CdkTestingStack extends cdk.Stack {
     const trigger = new CfnTrigger(this, 'ThirdPartyIntegration', {
       projectId: atlasProps.projId,
       profile: atlasProps.profile,
+      name: "mytrigger",
       type: "DATABASE",
       appId: atlasProps.appId,
       databaseTrigger: {
@@ -45,7 +46,7 @@ export class CdkTestingStack extends cdk.Stack {
 
   getContextProps(): AtlasStackProps {
     const projId = this.node.tryGetContext('projId');
-    if (!projId){
+    if (!projId) {
       throw "No context value specified for projId. Please specify via the cdk context."
     }
     const appId = this.node.tryGetContext('appId');
@@ -55,14 +56,14 @@ export class CdkTestingStack extends cdk.Stack {
     const serviceId = this.node.tryGetContext('serviceId');
     const functionId = this.node.tryGetContext('functionId');
     const functionName = this.node.tryGetContext('functionName');
-    
+
     return {
       projId,
       profile,
       appId,
       dbName,
       collection,
-      serviceId, 
+      serviceId,
       functionId,
       functionName
     }

examples/l1-resources/trigger.ts

@@ -35,14 +35,14 @@ export interface CfnTriggerProps {
    *
    * @schema CfnTriggerProps#Name
    */
-  readonly name?: string;
+  readonly name: string;
 
   /**
    * The trigger's type.
    *
    * @schema CfnTriggerProps#Type
    */
-  readonly type?: string;
+  readonly type: string;
 
   /**
    * If `true`, the trigger is disabled and does not listen for events or execute.

src/l1-resources/trigger/index.ts

@@ -19,6 +19,8 @@ import { CfnTrigger } from "../../../src/l1-resources/trigger";
 const RESOURCE_NAME = "MongoDB::Atlas::Trigger";
 const PROJECT_ID = "testProjectId";
 const APPID = "appId";
+const NAME = "name";
+const TYPE = "type";
 
 test("Trigger construct should contain default properties", () => {
   const mockApp = new App();
@@ -27,12 +29,16 @@ test("Trigger construct should contain default properties", () => {
   new CfnTrigger(stack, "testing-stack", {
     projectId: PROJECT_ID,
     appId: APPID,
+    name: NAME,
+    type: TYPE,
   });
 
   const template = Template.fromStack(stack);
 
   template.hasResourceProperties(RESOURCE_NAME, {
     ProjectId: PROJECT_ID,
     AppId: APPID,
+    Name: NAME,
+    Type: TYPE,
   });
 });