fix: INTMDB-1155 Atlas Basic L3 ip access list made mandatory (#147)

Author: Adelmar92

API.md

@@ -114,7 +114,6 @@ export class AtlasBasic extends Construct {
       {
         profile: props.profile,
         projectId: this.mProject.attrId,
-        accessList: props.ipAccessListProps?.accessList,
         ...props.ipAccessListProps,
       }
     );

src/l3-resources/atlas-basic/index.ts

@@ -40,7 +40,7 @@ export interface AtlasBasicProps {
    * @type {IpAccessListProps}
    * @memberof AtlasBasicProps
    */
-  readonly ipAccessListProps?: IpAccessListProps;
+  readonly ipAccessListProps: IpAccessListProps;
 }
 
 export interface AtlasServerlessBasicProps {

src/l3-resources/common/props.ts

@@ -19,6 +19,8 @@ import * as l3 from "../../../src";
 const RESOURCE_NAME_PROJECT = "MongoDB::Atlas::Project";
 const RESOURCE_NAME_CLUSTER = "MongoDB::Atlas::Cluster";
 const RESOURCE_NAME_DB_USER = "MongoDB::Atlas::DatabaseUser";
+const RESOURCE_NAME_PROJECT_IP_ACCESS_LIST =
+  "MongoDB::Atlas::ProjectIpAccessList";
 const PROJECT_ID = "testProjectId";
 const ORG_ID = "testProjectId";
 const PROJECT_NAME = "test";
@@ -29,6 +31,7 @@ const DATABASE_USER_NAME = "atlas-user";
 const ADMIN_DB = "admin";
 const ROLE_NAME = "atlasAdmin";
 const PWD = "test";
+const IP_ACCESS = "0000";
 
 test("AtlasBasis construct should contain default properties", () => {
   const mockApp = new App();
@@ -61,6 +64,9 @@ test("AtlasBasis construct should contain default properties", () => {
       databaseName: DATABASE_NAME,
       password: PWD,
     },
+    ipAccessListProps: {
+      accessList: [{ ipAddress: IP_ACCESS, comment: "My first IP address" }],
+    },
   });
 
   const template = Template.fromStack(stack);
@@ -101,4 +107,8 @@ test("AtlasBasis construct should contain default properties", () => {
       },
     ],
   });
+
+  template.hasResourceProperties(RESOURCE_NAME_PROJECT_IP_ACCESS_LIST, {
+    AccessList: [{ IPAddress: IP_ACCESS, Comment: "My first IP address" }],
+  });
 });