Skip to content

Conversation

@erabil-mdb
Copy link
Contributor

Proposed changes

Jira ticket: CLOUDP-#290399

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • I have tested the CDK constructor in a CFN stack. See TESTING.md
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@erabil-mdb erabil-mdb requested a review from a team as a code owner February 4, 2025 18:46
Copy link

@jxiao jxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resource policy changes LGTM! Deferring to APIx for CDK specific checklist items

Copy link
Collaborator

@EspenAlbert EspenAlbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@EspenAlbert EspenAlbert merged commit 67e9673 into mongodb:main Feb 10, 2025
7 of 8 checks passed
@EspenAlbert
Copy link
Collaborator

Bypassing required checks as this is a doc update only and will be fixed by #406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants